Review main Merged

92485[FEATURE] Make page type "preview" possibility configurable through TCA

Benni Mack CR +2 V +2 Normal +165 −56 updated 01/30/26, 11:46

Commit message

This change introduces a new TCA option `isViewable` for page types
to configure whether a specific doktype can be linked in the
page browser and frontend typolink generation.

By default, all page types are viewable unless explicitly set to false.

TYPO3 now marks the following page types as non-viewable in TCA:
- Spacer (doktype 199)
- Sys Folder (doktype 254)

The existing TSconfig option TCEMAIN.preview.disableButtonForDokType
is also respected when determining viewability in the backend.

This way, the option is centralized, configurable and applied
everywhere.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 1420

  1. Benni Mack uploaded patch set 1 01/23/26, 16:59

  2. core-ci voted on patch set 1 V -1 01/23/26, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94191

  3. Benni Mack uploaded patch set 2 V -1 01/23/26, 18:41

  4. core-ci voted on patch set 2 V -1 01/23/26, 18:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94197

  5. Benni Mack commented on patch set 3 V -1 01/29/26, 11:44

    Published edit on patch set 2.
  6. Benni Mack marked it ready for review 01/29/26, 11:44

  7. core-ci voted on patch set 3 V -1 01/29/26, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94565

  8. Georg Ringer uploaded patch set 4 V -1 01/29/26, 13:53

  9. core-ci voted on patch set 4 V -1 01/29/26, 14:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94578

  10. Georg Ringer uploaded patch set 5 V -1 01/29/26, 14:54

  11. core-ci voted on patch set 5 V -1 01/29/26, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94588

  12. Benni Mack uploaded patch set 6 V -1 01/29/26, 16:36

  13. Benni Mack marked it ready for review 01/29/26, 16:36

  14. core-ci voted on patch set 6 V +1 01/29/26, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94591

  15. Georg Ringer voted on patch set 6 CR +1 V +1 01/29/26, 17:13

  16. Garvin Hicking commented on patch set 6 01/29/26, 18:44

    What about `TYPO3\CMS\Core\DataHandling\SlugHelper->resolveParentPageRecord()`?
  17. Benni Mack commented on patch set 6 01/30/26, 11:34

    Reply

    hey Garvin, that actually solves a different purpose than "isPreviewable". In case somebody wants to make this configurable, this should be done in the TCA which doktypes to skip...
  18. Garvin Hicking commented on patch set 6 CR +1 V +1 01/30/26, 11:43

    Reply

    Thanks, all good then :)
  19. Benni Mack commented on patch set 6 CR +2 V +2 01/30/26, 11:46

    thanks!
  20. Benni Mack merged patch set 7 01/30/26, 11:46