92485[FEATURE] Make page type "preview" possibility configurable through TCA
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 15
- Build/Sources/TypeScript/backend/tree/page-browser.ts+4 −6
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/PageProvider.php+3 −7
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php+1 −0
- typo3/sysext/backend/Classes/LinkHandler/PageLinkHandler.php+13 −2
- typo3/sysext/backend/Classes/Routing/PreviewUriBuilder.php+3 −12
- typo3/sysext/backend/Resources/Public/JavaScript/tree/page-browser.js+1 −1
- typo3/sysext/core/Classes/DataHandling/PageDoktypeRegistry.php+60 −0
- typo3/sysext/core/Configuration/TCA/pages.php+2 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-97898-TCAOptionIsViewableForPageTypes.rstnew+53 −0
- typo3/sysext/frontend/Classes/Page/PageInformationFactory.php+4 −2
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+3 −1
- typo3/sysext/redirects/Classes/EventListener/AddPageTypeZeroSource.php+6 −10
- typo3/sysext/redirects/Classes/EventListener/AddPlainSlugReplacementSource.php+6 −10
- typo3/sysext/redirects/Tests/Unit/Service/RedirectServiceTest.php+3 −0
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+3 −5
Review log 1420
-
Benni Mack uploaded patch set 1 01/23/26, 16:59
-
core-ci voted on patch set 1 V -1 01/23/26, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94191
-
Benni Mack uploaded patch set 2
V -101/23/26, 18:41 -
core-ci voted on patch set 2 V -1 01/23/26, 18:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94197
-
Benni Mack commented on patch set 3
V -101/29/26, 11:44Published edit on patch set 2. -
Benni Mack marked it ready for review 01/29/26, 11:44
-
core-ci voted on patch set 3 V -1 01/29/26, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94565
-
Georg Ringer uploaded patch set 4
V -101/29/26, 13:53 -
core-ci voted on patch set 4 V -1 01/29/26, 14:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94578
-
Georg Ringer uploaded patch set 5
V -101/29/26, 14:54 -
core-ci voted on patch set 5 V -1 01/29/26, 15:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94588
-
Benni Mack uploaded patch set 6
V -101/29/26, 16:36 -
Benni Mack marked it ready for review 01/29/26, 16:36
-
core-ci voted on patch set 6 V +1 01/29/26, 16:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94591
-
Georg Ringer voted on patch set 6 CR +1 V +1 01/29/26, 17:13
-
Garvin Hicking commented on patch set 6 01/29/26, 18:44
What about `TYPO3\CMS\Core\DataHandling\SlugHelper->resolveParentPageRecord()`? -
Benni Mack commented on patch set 6 01/30/26, 11:34
Reply
hey Garvin, that actually solves a different purpose than "isPreviewable". In case somebody wants to make this configurable, this should be done in the TCA which doktypes to skip... -
Garvin Hicking commented on patch set 6 CR +1 V +1 01/30/26, 11:43
Reply
Thanks, all good then :) -
Benni Mack commented on patch set 6 CR +2 V +2 01/30/26, 11:46
thanks! -
Benni Mack merged patch set 7 01/30/26, 11:46