92488[TASK] Improve QR Code functionality for page preview
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Guido Schmechel +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Guido Schmechel +1
- core-ci +1 CI
Issues 2
Files 17
- Build/Sources/Sass/element/typo3-qrcode.scss+13 −6
- Build/Sources/TypeScript/backend/element/qrcode-element.ts+10 −22
- Build/Sources/TypeScript/backend/element/qrcode-modal-button.ts+2 −1
- Build/Sources/TypeScript/backend/context-menu-actions.ts+33 −1
- Build/Sources/TypeScript/backend/copy-to-clipboard.ts+4 −0
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/PageProvider.php+7 −1
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+1 −1
- typo3/sysext/backend/Classes/Controller/RecordListController.php+1 −1
- typo3/sysext/backend/Classes/Template/Components/ComponentFactory.php+0 −1
- typo3/sysext/backend/Resources/Private/Language/qrcode.xlf+0 −3
- typo3/sysext/backend/Resources/Public/Css/backend.css+3 −2
- typo3/sysext/backend/Resources/Public/JavaScript/element/qrcode-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/element/qrcode-modal-button.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/context-menu-actions.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/copy-to-clipboard.js+1 −1
- typo3/sysext/redirects/Resources/Private/Templates/QrCode/Overview.fluid.html+1 −1
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+1 −4
Review log 1720
-
Oli Bartsch uploaded patch set 1 01/23/26, 21:51
-
core-ci voted on patch set 1 V +1 01/23/26, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94214
-
Garvin Hicking commented on patch set 1 01/23/26, 22:12
```suggestion displays the URL to copy, while the download ```Thanks! -
Simon Schaufelberger commented on patch set 1 V -1 01/23/26, 23:02
The copy URL button doesn't work in Firefox for me. It quickly becomes green but the clipboard doesn't contain the url. -
Oli Bartsch updated the commit message in patch set 2
V +101/24/26, 09:10 -
Oli Bartsch commented on patch set 2 01/24/26, 09:13
Reply
I've tested this specifically in firefox. The QR Code Modal uses the "copy-to-clipbaord" component, which I've introduced in I think v12. Since then there has been no single report of this component not working in Firefox. Maybe you can debug this on your end (JS Console etc.)Reply
Fix applied. -
core-ci voted on patch set 2 V +1 01/24/26, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94238
-
Guido Schmechel commented on patch set 2 CR +1 V +1 01/25/26, 08:00
Also explicitly tested in Firefox 147. URL was copied correctly. -
Simon Schaufelberger commented on patch set 2 01/25/26, 11:23
Reply
I'm using FF 136.0 which is the latest version on Ubuntu 20.04 LTS (I know, a bit outdated). Maybe some compatibility issue? When was this API introduced? Copying code snippets on GitHub works fine for example. -
Garvin Hicking commented on patch set 2 CR +1 V +1 01/25/26, 11:54
Works for me (also firefox) and I love the cleaner button positioning in the iteration. Thanks! -
Simon Schaufelberger commented on patch set 2 01/25/26, 13:54
Reply
🤦 navigator.clipboard only works with https! I think this needs to be considered as I'm running my TYPO3 test installation locally under http and my customer's intranet also works under http. I don't know what I would expect in this case. Maybe an error message that it didn't work? Maybe disable the feature if not under https? -
Oli Bartsch uploaded patch set 3
CR +1V +101/26/26, 12:11 -
Oli Bartsch commented on patch set 3 01/26/26, 12:11
Reply
Sure, but there is an `else` part in the component, which has a fallback. So I've tested it in firefox with http:// and it still works. Anyways, I added an indication in case copy did not work. -
Oli Bartsch commented on patch set 3 01/26/26, 12:11
Reply
Done -
core-ci voted on patch set 3 V +1 01/26/26, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94357
-
Simon Schaufelberger commented on patch set 3 01/26/26, 13:15
Reply
I've seen it. I made sure the sources are fetched without the browser cache. Very strange. Thank you for testing as well. I don't want to block it if the tests from other people are green. -
Garvin Hicking voted on patch set 3 CR +1 V +1 01/26/26, 14:35
-
Guido Schmechel voted on patch set 3 CR +1 V +1 01/26/26, 15:40
-
Oli Bartsch voted on patch set 3 CR +2 V +2 01/26/26, 15:44
-
Oli Bartsch merged patch set 4 01/26/26, 15:44