Review main Merged

92488[TASK] Improve QR Code functionality for page preview

Oli Bartsch CR +2 V +2 Normal +80 −48 updated 01/26/26, 15:44

Commit message

This improves the recently introduced QR Code
functionality for page previews.

The QR Code for page previews now always
displays the URL to copy, while the download
options are only displayed in the QR Code module.
Those are different use-cases, which are therefore
now properly respected.

The button is rendered alongside the "view page"
button and does no longer have a label.

Additionally, the QR Code for page preview can
now also be accessed via the context menu.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Guido Schmechel +1
    • core-ci +1 CI

Issues 2

Files 17

Review log 1720

  1. Oli Bartsch uploaded patch set 1 01/23/26, 21:51

  2. core-ci voted on patch set 1 V +1 01/23/26, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94214

  3. Garvin Hicking commented on patch set 1 01/23/26, 22:12

    ```suggestion displays the URL to copy, while the download ```
    Thanks!
  4. Simon Schaufelberger commented on patch set 1 V -1 01/23/26, 23:02

    The copy URL button doesn't work in Firefox for me. It quickly becomes green but the clipboard doesn't contain the url.
  5. Oli Bartsch updated the commit message in patch set 2 V +1 01/24/26, 09:10

  6. Oli Bartsch commented on patch set 2 01/24/26, 09:13

    Reply

    I've tested this specifically in firefox. The QR Code Modal uses the "copy-to-clipbaord" component, which I've introduced in I think v12. Since then there has been no single report of this component not working in Firefox. Maybe you can debug this on your end (JS Console etc.)

    Reply

    Fix applied.
  7. core-ci voted on patch set 2 V +1 01/24/26, 09:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94238

  8. Guido Schmechel commented on patch set 2 CR +1 V +1 01/25/26, 08:00

    Also explicitly tested in Firefox 147. URL was copied correctly.
  9. Simon Schaufelberger commented on patch set 2 01/25/26, 11:23

    Reply

    I'm using FF 136.0 which is the latest version on Ubuntu 20.04 LTS (I know, a bit outdated). Maybe some compatibility issue? When was this API introduced? Copying code snippets on GitHub works fine for example.
  10. Garvin Hicking commented on patch set 2 CR +1 V +1 01/25/26, 11:54

    Works for me (also firefox) and I love the cleaner button positioning in the iteration. Thanks!
  11. Simon Schaufelberger commented on patch set 2 01/25/26, 13:54

    Reply

    🤦 navigator.clipboard only works with https! I think this needs to be considered as I'm running my TYPO3 test installation locally under http and my customer's intranet also works under http. I don't know what I would expect in this case. Maybe an error message that it didn't work? Maybe disable the feature if not under https?
  12. Oli Bartsch uploaded patch set 3 CR +1 V +1 01/26/26, 12:11

  13. Oli Bartsch commented on patch set 3 01/26/26, 12:11

    Reply

    Sure, but there is an `else` part in the component, which has a fallback. So I've tested it in firefox with http:// and it still works. Anyways, I added an indication in case copy did not work.
  14. Oli Bartsch commented on patch set 3 01/26/26, 12:11

    Reply

    Done
  15. core-ci voted on patch set 3 V +1 01/26/26, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94357

  16. Simon Schaufelberger commented on patch set 3 01/26/26, 13:15

    Reply

    I've seen it. I made sure the sources are fetched without the browser cache. Very strange. Thank you for testing as well. I don't want to block it if the tests from other people are green.
  17. Garvin Hicking voted on patch set 3 CR +1 V +1 01/26/26, 14:35

  18. Guido Schmechel voted on patch set 3 CR +1 V +1 01/26/26, 15:40

  19. Oli Bartsch voted on patch set 3 CR +2 V +2 01/26/26, 15:44

  20. Oli Bartsch merged patch set 4 01/26/26, 15:44