Review main Merged

92498[FEATURE] Add "change_stage" command to DataHandler

Benni Mack CR +2 V +2 Hard +541 −87 updated 10/12/26, 18:35

Commit message

This introduces a new "change_stage" command for workspaces that
provides a cleaner API for changing the stage of workspace records,
consistent with the recently introduced "publish" command.

Command structure:
$commandMap = [
    'pages' => [
        123 => [
            'change_stage' => [
                'stage' => -10,
                'comment' => 'Ready for review',
            ]
        ]
    ]
];

This simplifies the stage change API compared to the legacy "version"
command with "action" => "setStage", which required nested parameters.

The "version" command with "setStage" action continues to work for
backward compatibility. The dependency resolver handles both formats
and keeps the shape a record was requested with. Dependent records
take the shape of the requested record, so processCmdmap hooks see
the command as the caller sent it. If both commands address the same
record, "change_stage" takes precedence.

The workspaces backend module now sends "change_stage" commands.

Exploding comma-separated uid lists for "setStage" is removed, as
DataHandler::start() already rejects such command map keys.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 811

  1. Benni Mack uploaded patch set 1 01/24/26, 20:30

  2. core-ci voted on patch set 1 V +1 01/24/26, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94269

  3. Benni Mack uploaded patch set 2 V +1 10/10/26, 07:19

  4. Benni Mack marked it ready for review 10/10/26, 07:19

  5. core-ci voted on patch set 2 V +1 10/10/26, 07:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110759

  6. Oli Bartsch uploaded patch set 3 V +1 10/10/26, 08:20

  7. core-ci voted on patch set 3 V +1 10/10/26, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110770

  8. Oli Bartsch voted on patch set 3 CR +1 V +1 10/10/26, 09:29

  9. Simon Schaufelberger voted on patch set 3 CR +1 V +1 10/12/26, 14:18

  10. Georg Ringer voted on patch set 3 CR +2 V +2 10/12/26, 18:35

  11. Georg Ringer merged patch set 4 10/12/26, 18:35