Review main Abandoned

92499[WIP][TASK] Add test to use non-english locallang.xlf files

Garvin Hicking CR 0 V -1 Normal +124 −0 updated 08/10/26, 08:09

Commit message

The docs [1] establish:

  The original file must always be in English. Do not create files
  with the prefix en.

This (failing) test is a WIP to prove that at least in v14
this does not work, and the docs statement should remain
in effect.

It also helps in case I'm fundamentally misunderstanding
the goal and can be reworked by anyone :)

For another scenario, see [2] and [3]

[1] https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Localization/XliffFormat.html#xliff-translated-file-name
[2] https://review.typo3.org/c/Packages/TYPO3.CMS/+/92514
[3] https://forge.typo3.org/issues/107990#change-552937

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Files 7

Review log 69

  1. Garvin Hicking uploaded patch set 1 01/24/26, 21:37

  2. core-ci voted on patch set 1 V -1 01/24/26, 21:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94271

  3. Garvin Hicking updated the commit message in patch set 2 V -1 01/26/26, 14:13

  4. core-ci voted on patch set 2 V -1 01/26/26, 14:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94365

  5. Benni Mack marked it work in progress 04/21/26, 14:34

  6. Ayke Halder commented on patch set 2 07/05/26, 16:14

    This beahaviour was introduced with Change-Id I78bf3166c51f78244c7125f77a82e5eb9fe6a66c The use case for this change was later introduced with Change-Id I3d4daedb3d407c9ff2716110dd4ae4faf3740851
  7. Garvin Hicking uploaded patch set 3 V -1 07/28/26, 06:44

  8. core-ci voted on patch set 3 V -1 07/28/26, 06:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105523

  9. Garvin Hicking abandoned the change 08/10/26, 08:09