92500[FEATURE] Console command to analyse Fluid templates
Commit message
Review
-
Code review CR +2 Done
- Simon Praetorius +2
- Garvin Hicking +1
- Guido Schmechel +1
-
Verified V +2 Done
- Simon Praetorius +2
- Garvin Hicking +1
- Guido Schmechel +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-108148-FluidUnderscoreVariablePrefix.rst+3 −3
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-108229-FluidCacheWarmup.rst+3 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-108763-ConsoleCommandToAnalyseFluidTemplates.rstnew+131 −0
- typo3/sysext/fluid/Classes/Command/AnalyseCommand.php1new+107 −0
- typo3/sysext/fluid/Classes/Command/SchemaCommand.php+1 −1
- typo3/sysext/fluid/Classes/Command/WarmupCommand.php+24 −7
Review log 1824
-
Simon Praetorius uploaded patch set 1 01/25/26, 10:03
-
core-ci voted on patch set 1 V +1 01/25/26, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94298
-
Garvin Hicking commented on patch set 1 01/25/26, 10:18
-
Simon Praetorius uploaded patch set 2
V +101/25/26, 10:47 -
core-ci voted on patch set 2 V +1 01/25/26, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94302
-
Anja Leichsenring voted on patch set 2 CR +1 V +1 01/25/26, 11:02
-
Guido Schmechel commented on patch set 2 01/25/26, 11:15
The following test ran on my system: - Unknown ViewHelper f:variable2 was marked as an error The following test did not work for me: This code was added to typo3/sysext/fluid_styled_content/Resources/Private/Templates/Table.fluid.html: <f:variable name="_blubb">Test</f:variable> <f:variable name="_temp" value="a temporary value" /> This was not recognised: "[OK] 506 analysed templates without errors or deprecations" Since I don't know if I have misunderstood something here, I won't give it a -1. -
Simon Praetorius commented on patch set 2 01/25/26, 11:20
Reply
Variables are recognized on access, not on definition. Could you try `{_temp}`? -
Garvin Hicking commented on patch set 2 CR -1 01/25/26, 11:36
on it for a small verbose addition -
Guido Schmechel commented on patch set 2 01/25/26, 11:39
Reply
Perfect. Thank you for clarifying :-) -
Garvin Hicking uploaded patch set 3
CR +1V +101/25/26, 11:48 -
core-ci voted on patch set 3 V +1 01/25/26, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94309
-
Garvin Hicking uploaded patch set 4
V +101/25/26, 12:02 -
Garvin Hicking uploaded patch set 5 01/25/26, 12:03
-
core-ci voted on patch set 4 V +1 01/25/26, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94310
-
core-ci voted on patch set 5 V +1 01/25/26, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94311
-
Simon Praetorius uploaded patch set 6
V +101/25/26, 12:20 -
Simon Praetorius commented on patch set 5 01/25/26, 12:20
Reply
Done -
Garvin Hicking commented on patch set 5 CR +1 V +1 01/25/26, 12:20
Reply
Done -
core-ci voted on patch set 6 V +1 01/25/26, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94312
-
Garvin Hicking voted on patch set 6 CR +1 V +1 01/25/26, 12:46
-
Guido Schmechel voted on patch set 6 CR +1 V +1 01/25/26, 12:57
-
Simon Praetorius voted on patch set 6 CR +2 V +2 01/25/26, 14:02
-
Simon Praetorius merged patch set 7 01/25/26, 14:02
AnalyseCommand.php:38