Review main Merged

92502[BUGFIX] Skip transient properties in Extbase validation

Benni Mack CR +2 V +2 Normal +88 −1 updated 01/28/26, 16:28

Commit message

Extbase validation threw an exception when a model had a protected
property typed as another model class without public accessor methods,
even when the property was marked as #[Transient].

The ValidatorResolver now checks for transient properties before adding
auto-generated validators for model-typed properties. This is correct
because transient properties are not persisted and may not have public
accessors for runtime-only use cases.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Garvin Hicking +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Markus Klein +1
    • Garvin Hicking +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Benni Mack uploaded patch set 1 01/25/26, 11:37

  2. Benni Mack updated the commit message in patch set 2 01/25/26, 11:38

  3. Benni Mack wrote 01/25/26, 11:38

    Topic set to extbase
  4. Oliver Klee voted on patch set 2 V +1 01/25/26, 11:40

  5. core-ci voted on patch set 1 V +1 01/25/26, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94307

  6. core-ci voted on patch set 2 V +1 01/25/26, 11:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94308

  7. Markus Klein commented on patch set 2 CR +1 V +1 01/26/26, 07:11

    Thanks for the fix
  8. Oliver Hader voted on patch set 2 CR +1 V +1 01/27/26, 22:35

  9. Garvin Hicking voted on patch set 2 CR +1 V +1 01/28/26, 06:42

  10. Benni Mack voted on patch set 2 CR +2 V +2 01/28/26, 16:28

  11. Benni Mack merged patch set 3 01/28/26, 16:28