92505[BUGFIX] Fix live-search modal not opening via shortcut
Commit message
Review
-
Code review CR -1
- Oli Bartsch +1
- Andreas Kienast -1
-
Verified V +1
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 4
- Build/Sources/TypeScript/backend/live-search/live-search-shortcut.ts+1 −1
- Build/Sources/TypeScript/backend/toolbar/live-search.ts+2 −1
- typo3/sysext/backend/Resources/Public/JavaScript/live-search/live-search-shortcut.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar/live-search.js+1 −1
Review log 67
-
Richard Krikler uploaded patch set 1 01/25/26, 16:38
-
core-ci voted on patch set 1 V +1 01/25/26, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94317
-
Oli Bartsch voted on patch set 1 CR +1 V +1 01/26/26, 09:38
-
Andreas Kienast commented on patch set 1 CR -1 01/30/26, 08:13
I'm undecided here. This patch solves the imminent issue, but does not solve the _actual_ issie how hotkeys are bound. -
Oli Bartsch commented on patch set 1 01/30/26, 09:41
Reply
True, but this fixes the bug. However, are you about to investigate this further? Otherwise I suggest to just use this for now. -
Andreas Kienast commented on patch set 1 01/30/26, 10:49
Reply Unresolved
I'm currently working on another patch for the general issue. -
Andreas Kienast abandoned the change 01/30/26, 12:03
Hey @typo3@richardkrikler.at, thank you very much for your patch. After investigating where the actual issue comes from, we've decided to come up with another approach that solves the issue on a more generic level. Feel free to check the new patch at https://review.typo3.org/c/Packages/TYPO3.CMS/+/92584.