92508[TASK] Add functional test to ensure integrity of Core fluid templates
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Simon Praetorius +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- Simon Praetorius +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 3
Files 4
- typo3/sysext/fluid/Tests/Functional/Fixtures/InvalidFluidTemplates/invalidTemplateDueToInternalVariable.fluid.htmlnew+2 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/InvalidFluidTemplates/invalidTemplateDueToSyntaxError.fluid.htmlnew+6 −0
- typo3/sysext/fluid/Tests/Functional/Fixtures/InvalidFluidTemplates/invalidTemplateDueToViewHelper.fluid.htmlnew+2 −0
- typo3/sysext/fluid/Tests/Functional/TemplateAnalyzerTest.phpnew+123 −0
Review log 3039
Show 914 earlier messages
-
Garvin Hicking uploaded patch set 1 01/25/26, 18:49
-
Garvin Hicking uploaded patch set 2 01/25/26, 18:55
-
core-ci voted on patch set 1 V -1 01/25/26, 18:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94321
-
Garvin Hicking uploaded patch set 3 01/25/26, 18:59
-
Garvin Hicking uploaded patch set 4 01/25/26, 19:00
Expected red -
Garvin Hicking uploaded patch set 5 01/25/26, 19:00
Expected green -
core-ci voted on patch set 2 V -1 01/25/26, 19:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94322
-
core-ci voted on patch set 3 V +1 01/25/26, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94323
-
core-ci voted on patch set 5 V +1 01/25/26, 19:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94325
-
core-ci voted on patch set 4 V -1 01/25/26, 19:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94324
-
Garvin Hicking commented on patch set 5 01/25/26, 19:22
See Patchset 4 for an example how a red test with invalid fluid file would look like. -
Simon Schaufelberger commented on patch set 5 01/25/26, 20:49
TemplateAnalyserTest.php:35i would give the method some air to breath (add one empty line before).TemplateAnalyserTest.php:49just a idea: I'm using `.fixture` in Fractor to make it clear that this is a fixture file and not used as original source. Would you find this a good idea? -
Garvin Hicking commented on patch set 5 CR -1 01/26/26, 05:45
TemplateAnalyserTest.php:49ReplyI will refactor this to put the actual files in a fixture extension instead, and remove the renaming stuff. -
Garvin Hicking uploaded patch set 6
CR -1V +101/26/26, 07:26refactor to not copy files around
-
core-ci voted on patch set 6 V +1 01/26/26, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94337
-
Garvin Hicking commented on patch set 6 01/26/26, 08:14
TemplateAnalyserTest.php:35ReplyDoneTemplateAnalyserTest.php:49ReplyDone -
Oliver Klee commented on patch set 6 01/26/26, 08:37
TemplateAnalyserTest.php:29We're using American English in the Core: ```suggestion final class TemplateAnalyzerTest extends FunctionalTestCase ``` -
Garvin Hicking commented on patch set 6 01/26/26, 11:45
TemplateAnalyserTest.php:29ReplyThere is a mixture of "analyze" and "analyse" in the codebase right now. We should IMO address that in a distinct follow-up patch. The recently introduced method for example is called 'analyse' and only uses 'analyze' as an alias. -
Stefan Bürk commented on patch set 6 CR -1 01/26/26, 15:45
Want to check something, temp -1 on that ... -
Stefan Bürk commented on patch set 6 01/26/26, 17:19
Reply
.. nevermind. -
Stefan Bürk voted on patch set 6 CR 0 01/26/26, 17:23
-
Oliver Klee voted on patch set 6 V +1 01/26/26, 18:04
-
Simon Schaufelberger commented on patch set 6 01/26/26, 19:07
TemplateAnalyserTest.php:46this comment is not correct anymore -
Garvin Hicking commented on patch set 7
V +101/26/26, 20:01Published edit on patch set 6. -
Garvin Hicking commented on patch set 7 01/26/26, 20:01
TemplateAnalyserTest.php:46ReplyDone -
core-ci voted on patch set 7 V +1 01/26/26, 20:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94379
-
Oliver Klee voted on patch set 7 V +1 01/26/26, 21:12
-
Simon Schaufelberger voted on patch set 7 CR +1 V +1 01/27/26, 00:00
-
Garvin Hicking rebased onto patch set 8
CR +1V +104/09/26, 09:42 -
Simon Praetorius commented on patch set 8 04/09/26, 09:44
TemplateAnalyserTest.php:117Not sure if this survives the rebase. But I'd like to improve this part if possible. Other than that, I'm fine with the patch. -
core-ci voted on patch set 8 V -1 04/09/26, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99833
-
Garvin Hicking uploaded patch set 9
V -104/09/26, 18:27 -
core-ci voted on patch set 9 V +1 04/09/26, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99878
-
Simon Schaufelberger voted on patch set 9 CR +1 V +1 04/09/26, 18:42
-
Garvin Hicking commented on patch set 9 04/09/26, 18:46
TemplateAnalyserTest.php:117ReplyThanks for the feedback @simon@praetorius.me - I adjusted it to the new format. Would that be fine for you? -
Oliver Klee voted on patch set 9 V +1 04/10/26, 07:13
-
Simon Praetorius commented on patch set 9 CR +1 V +1 04/10/26, 07:17
TemplateAnalyserTest.php:117ReplyDone -
Garvin Hicking voted on patch set 9 CR +2 V +2 04/10/26, 07:41
-
Garvin Hicking merged patch set 10 04/10/26, 07:41