Review 13.4 Merged

92511[BUGFIX] Prevent open_basedir warnings for file thumbnails

Simon Praetorius CR +2 V +2 Easy +1 −1 updated 02/27/26, 09:20

Commit message

There are circumstances where legacy fileadmin urls are passed to
`FormEngineUtility::getIconHtml()`. This leads to an `is_file()`
check for a path like `/fileadmin/path/to/image.png`, which returns
`false` and leads to the public path being appended in the second
`is_file()`.

If `open_basedir` is active, that first `is_file()` call already
triggers a warning in the backend, even though a fallback is in place.
To prevent warnings in this location, both `is_file()` calls now use
the `@` operator.

This code has been refactored in main, so this patch is only relevant
for v13.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Simon Praetorius uploaded patch set 1 01/26/26, 11:32

  2. core-ci voted on patch set 1 V +1 01/26/26, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94355

  3. Georg Ringer voted on patch set 1 CR +1 V +1 02/27/26, 08:01

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 02/27/26, 08:55

    thx
  5. Oliver Klee voted on patch set 1 CR +1 02/27/26, 09:11

  6. Benni Mack voted on patch set 1 CR +2 V +2 02/27/26, 09:20

  7. Benni Mack merged patch set 2 02/27/26, 09:20