92513[FEATURE] Add option to set user interface language
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2231
Show 36 earlier messages
-
Sebastien Convers uploaded patch set 1 01/26/26, 14:01
-
core-ci voted on patch set 1 V -1 01/26/26, 14:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94363
-
Sebastien Convers uploaded patch set 2
V -101/26/26, 14:39 -
core-ci voted on patch set 2 V -1 01/26/26, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94370
-
Sebastien Convers uploaded patch set 3
V -101/26/26, 15:11 -
core-ci voted on patch set 3 V +1 01/26/26, 15:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94371
-
Guido Schmechel commented on patch set 3 01/26/26, 17:17
First feedback: - The QuestionHelper for the locale is not yet being used correctly - Please also adjust the help text and describe the new ENV - As this is a feature, an RST is still missing -
Garvin Hicking commented on patch set 3 01/26/26, 19:16
Good idea - but I would argue the terminology here would be "language" and not "locale"? For locale I would expect values like "de_DE" and not just "de"? -
Sebastien Convers commented on patch set 3 01/27/26, 07:47
Reply
Thanks for feedback! About the QuestionHelper, i choose not to use it. It would make a huge choices list, and i was not sure it was good for the readability of the command, as you would need to scroll up to see what was the question. You think it's mandatory? -
Sebastien Convers commented on patch set 3 01/27/26, 07:58
Reply
Was my first thought aswell but in TYPO3\CMS\Core\Localization\Locales, keys of $languages array seems to be designated as "locales" so i changed? -
Benni Mack commented on patch set 3 01/27/26, 10:02
Reply
Use "language" (the DB field is backend_users.lang) -
Sebastien Convers uploaded patch set 4
V +101/27/26, 13:14 -
Sebastien Convers commented on patch set 4 01/27/26, 13:14
Reply
Done -
core-ci voted on patch set 4 V +1 01/27/26, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94427
-
Sebastien Convers uploaded patch set 5
V +101/27/26, 13:35 -
Sebastien Convers commented on patch set 5 01/27/26, 13:38
I'm now using language instead of locale, i added the RST file. I also reworked the QuestionHelper part: i'm using simple "Question" with setAutocompleterValues, because i think a "ChoiceQuestion" would not be readable because of scroll required to read the question. -
core-ci voted on patch set 5 V -1 01/27/26, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94428
-
Sebastien Convers uploaded patch set 6
V -101/27/26, 15:14 -
core-ci voted on patch set 6 V +1 01/27/26, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94432
-
Sebastien Convers commented on patch set 6 01/27/26, 16:02
Reply
Done -
Benni Mack updated the commit message in patch set 7
V +101/27/26, 16:11 -
core-ci voted on patch set 7 V +1 01/27/26, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94434
-
Garvin Hicking commented on patch set 7 01/27/26, 17:48
```suggestion Add an option `language` allowing to set the backend user interface language when ``````suggestion If the option is set, it will be validated against available languages. ``````suggestion If he option is not set in CLI, no choice will be asked, it ```CreateBackendUserCommand.php:328```suggestion 'The given language "' . $language . '" is not supported.', ```Feature-108776-AllowToSetUserInterfaceLanguageWhenUsingCLIToCreateUser.rst:6```suggestion Feature: #108776 - Allow to set user interface language when using CLI to create user ```Feature-108776-AllowToSetUserInterfaceLanguageWhenUsingCLIToCreateUser.rst:14```suggestion The CLI command `backend:user:create` now supports the option `--language` (or `-l`) to set the desired language for the user interface. ``` -
Sebastien Convers uploaded patch set 8
V +101/28/26, 08:07 -
Sebastien Convers updated the commit message in patch set 9 01/28/26, 08:10
-
Sebastien Convers commented on patch set 9 01/28/26, 08:11
Reply
AcknowledgedReply
DoneReply
AcknowledgedCreateBackendUserCommand.php:328ReplyDoneFeature-108776-AllowToSetUserInterfaceLanguageWhenUsingCLIToCreateUser.rst:6ReplyDoneFeature-108776-AllowToSetUserInterfaceLanguageWhenUsingCLIToCreateUser.rst:14ReplyDone -
core-ci voted on patch set 8 V +1 01/28/26, 08:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94481
-
core-ci voted on patch set 9 V +1 01/28/26, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94482
-
Garvin Hicking commented on patch set 9 CR +1 V +1 01/28/26, 09:17
Thanks! 😊 -
Benni Mack voted on patch set 9 CR +2 V +2 01/28/26, 14:15
-
Benni Mack merged patch set 10 01/28/26, 14:15