Review main Merged

92515[DOCS] Create Camino Theme documentation

Tom Warwick CR +2 V +2 Hard +474 −71 updated 01/29/26, 11:05

Commit message

This commit contains new documentation for the Camino theme.

The documentation shows new users how to install the extension and load it.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Lina Wolf +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Lina Wolf +1
    • core-ci +1 CI

Issues 2

Files 35

Show 15 more files

Review log 3340

Show 1315 earlier messages
  1. Tom Warwick uploaded patch set 1 01/26/26, 14:19

  2. Andreas Kienast commented on patch set 1 CR -1 01/26/26, 14:22

    We'll do some minor adjustment here.
  3. Tom Warwick updated the commit message in patch set 2 CR -1 01/26/26, 14:25

  4. Andreas Kienast commented on patch set 2 01/26/26, 14:26

    Reply

    Done
  5. core-ci voted on patch set 1 V +1 01/26/26, 14:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94367

  6. core-ci voted on patch set 2 V +1 01/26/26, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94368

  7. Garvin Hicking commented on patch set 2 CR +1 V +1 01/26/26, 14:41

    Excellent. No notes. 😊
  8. Lina Wolf commented on patch set 2 CR -1 01/27/26, 07:50

    This does not follow the code guidelines and TYPO3 Documentation standards

    Index.rst:11

    All headers must have anchors for permalinks

    Index.rst:21

    Headers must be in sentence case

    Index.rst:24

    Wrap lines at 80 chars
  9. Lina Wolf commented on patch set 2 01/27/26, 07:53

    Index.rst:23

    Headlines of level 2 must be underlined with "=", anchor is missing. See [Headlines and anchors](https://docs.typo3.org/permalink/h2document:headlines-and-sections)

    Index.rst:46

    Use the new zoom feature: [Image zoom and lightbox features](https://docs.typo3.org/permalink/h2document:image-zoom), this also improves readability on mobile devices

    Index.rst:48

    Sentence case

    Index.rst:53

    Lines should be wrapped at 80 chars
  10. Lina Wolf commented on patch set 2 01/27/26, 08:05

    Index.rst:6

    Use headers that can be understood without context, as these are shown in the internal search, interpreted by google and used in links

    Index.rst:10

    No anchor, must be sentence case

    Index.rst:15

    Index.rst:66

    TYPO3 documentation should use direct, imperative instructions. Suggested wording: "Save your changes. Then clear the cache." (with a link to how to clear the cache). It is a general rule that we do not use contractions. Documentation should use the full forms (for example, “do not”), and preferably avoid negative constructions altogether in favor of clear, direct instructions.
  11. Lina Wolf commented on patch set 2 01/27/26, 08:09

    Index.rst:3

    The Core uses an indentation of 4 spaces, see the ".editorconfig", while we do not do unnessesary mass changes to existing documentation new must follow this.
  12. Lina Wolf commented on patch set 2 01/27/26, 08:11

    Index.rst:49

    Classic mode installations
  13. Garvin Hicking commented on patch set 2 CR 0 V 0 01/27/26, 08:12

    Lina mentioned formatting things that I sadly often forget myself. We'll need to create a checklist for that, but I agree that should be adjusted.
  14. Andreas Kienast commented on patch set 2 01/27/26, 08:18

    Reply

    Since we already have "documentation rendering pre-merge" in the CI, can we have a basic linter as well?
  15. Lina Wolf commented on patch set 2 01/27/26, 08:22

    Reply

    We avoid Mass changes therefore old docs do not always follow these rules. Also there is no linter yet it would first have to be written
  1. Garvin Hicking commented on patch set 2 01/27/26, 08:32

    Reply

    The problem is that we have a lot of docs that don't follow the "guidelines" yet and would need to be migrated before we could put those rules that lina mentioned in place. Having said that, that would be helpful! Maybe once we have a checklist we can create a linter for it, in the render-guides repository directly, lina? Then we could call our container to do that, and would need no custom code. We should continue this in the render-guides issue tracker: https://github.com/TYPO3-Documentation/render-guides/issues/1157
  2. Tom Warwick commented on patch set 2 01/27/26, 12:53

    Index.rst:49 Reply

    We literally had a meeting last year with Benji and members of the Docs team and discussed in detail why "Classic mode" should not be used anymore.
  3. Lina Wolf commented on patch set 2 01/27/26, 13:03

    Index.rst:49 Reply

    Do you have a source for that? The Core continues to use the wording "Clasic mode" see for example typo3/sysext/backend/Resources/Private/Language/locallang_toolbar.xlf toolbarItems.sysinfo.installationMethod.classic And the official docs are also switching back to use the word "Classic mode". As far as I remember Benji argued against the word "Legacy installation".
  4. Benjamin Kott commented on patch set 2 01/27/26, 14:56

    Index.rst:49 Reply

    Thats not correct @tom.warwick@typo3.org - we do not talk about Legacy Mode. I think you mixed something up, @112@linawolf.de is correct here with her remarks.
  5. Sarah McCarthy commented on patch set 2 01/28/26, 10:06

    Working on it
  6. Sarah McCarthy uploaded patch set 3 CR -1 V +1 01/28/26, 10:17

  7. Sarah McCarthy commented on patch set 3 CR +1 V +1 01/28/26, 10:19

    Added permalinks and checked language.
  8. Sarah McCarthy commented on patch set 3 01/28/26, 10:20

    Index.rst:48 Reply

    Done

    Index.rst:21 Reply

    Done
  9. core-ci voted on patch set 3 V +1 01/28/26, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94488

  10. Sarah McCarthy uploaded patch set 4 CR +1 V +1 01/28/26, 10:42

  11. Sarah McCarthy commented on patch set 4 01/28/26, 10:43

    Looks good:-)

    Index.rst:23 Reply

    Done

    Index.rst:53 Reply

    Done

    Index.rst:11 Reply

    Done

    Index.rst:24 Reply

    Done

    Index.rst:10 Reply

    Done

    Index.rst:15 Reply

    Done
  12. core-ci voted on patch set 4 V +1 01/28/26, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94491

  13. Sarah McCarthy uploaded patch set 5 V +1 01/28/26, 20:08

  14. Sarah McCarthy commented on patch set 5 CR +1 V +1 01/28/26, 20:10

    Resolved these. I'm not sure about the indentation of 4 spaces - I think this may have already been resolved?

    Index.rst:46 Reply

    Done

    Index.rst:6 Reply

    Done

    Index.rst:66 Reply

    Done

    Index.rst:49 Reply

    Done
  15. core-ci voted on patch set 5 V +1 01/28/26, 20:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94531

  16. Lina Wolf commented on patch set 5 CR -1 01/29/26, 07:35

    Working on it
  17. Lina Wolf uploaded patch set 6 CR +1 V +1 01/29/26, 09:12

  18. Lina Wolf commented on patch set 6 CR +1 V +1 01/29/26, 09:12

    Done

    Index.rst:3 Reply

    Done
  19. core-ci voted on patch set 6 V +1 01/29/26, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94558

  20. Lina Wolf uploaded patch set 7 CR +1 V +1 01/29/26, 09:25

  21. Lina Wolf voted on patch set 7 CR +1 V +1 01/29/26, 09:25

  22. core-ci voted on patch set 7 V +1 01/29/26, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94559

  23. Garvin Hicking voted on patch set 7 CR +1 V +1 01/29/26, 11:04

  24. Garvin Hicking voted on patch set 7 CR +2 V +2 01/29/26, 11:05

  25. Garvin Hicking merged patch set 8 01/29/26, 11:05