Review main Abandoned

92516[FEATURE] Support YAML imports in settings.definitions.yaml

Eric Harrer CR -1 V -1 Normal +152 −2 updated 01/26/26, 16:54

Commit message

Load site set settings definitions via YamlFileLoader to allow YAML
imports. This enables splitting settings definitions across multiple
files while keeping site sets self-contained.

Review

  • Code review CR -1
    • Garvin Hicking -1
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 9

Review log 67

  1. Eric Harrer uploaded patch set 1 01/26/26, 15:22

  2. core-ci voted on patch set 1 V -1 01/26/26, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94372

  3. Garvin Hicking commented on patch set 1 CR -1 01/26/26, 15:51

    I think we should not do this. It would allow "remapping" defaults and remove the authoritativeness / source-of-truth of a monolotical file.

    YamlSetDefinitionProvider.php:78

    IIRC not having imports here is a conscious decision for the Site Set self-contained workings, meaning we do not want to process further files because it could "bleed" into foreign extensions or directories and create cross-dependencies.
  4. Eric Harrer commented on patch set 1 01/26/26, 16:19

    YamlSetDefinitionProvider.php:78 Reply

    It can happen that `settings.definitions.yaml` becomes very large, so the desire to make this file splitable is understandable. However, `YamlFileLoader` does not seem to be the right solution here, as it goes too far. Would another splitting solution be acceptable that guarantees that “bleeding” into directories outside the Site Set is avoided?
  5. Garvin Hicking commented on patch set 1 01/26/26, 16:37

    YamlSetDefinitionProvider.php:78 Reply

    How about creating multiple site sets and split the definitions with that? Like an extension EXT:sitepackage could provide "sitepackage/settings-header", "sitepackage/settings-footer", "sitepackage/settings-socialmedia" etc.? I haven't worked too much with this on my own but I think you can also have sub-dependencies, so you could create a "sitepackage/settings-all" that depends on all the sub-site-sets...? Then the settings would also be separated on the UI side, that would be a win/win?
  6. Eric Harrer commented on patch set 1 01/26/26, 16:49

    Since it is possible to split large settings definitions across multiple site sets, which can be managed as sub-dependencies, this patch can be closed/rejected.

    YamlSetDefinitionProvider.php:78 Reply Unresolved

    Yes, subdependencies within site sets seem to be a useful approach for splitting up large setting definitions. Thanks for the food for thought!
  7. Garvin Hicking abandoned the change 01/26/26, 16:54

    thanks for the feedback! :)