92519[TASK] Use "en" instead of "default" as backend user language
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Anja Leichsenring +1
- Ayke Halder +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Anja Leichsenring +1
- Ayke Halder +1
- core-ci +1 CI
Issues 1
Files 46
- typo3/sysext/backend/Classes/Authentication/PasswordReset.php+1 −1
- typo3/sysext/backend/Classes/Command/CreateBackendUserCommand.php+1 −1
- typo3/sysext/backend/Classes/Command/DebugBackendModulesCommand.php+1 −1
- typo3/sysext/backend/Classes/Controller/AbstractFormEngineAjaxController.php+1 −1
- typo3/sysext/backend/Classes/Security/EmailLoginNotification.php+1 −1
- typo3/sysext/backend/Tests/Functional/Controller/ResetPasswordControllerTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/Form/Container/FilesControlContainerTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaCountryTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaRecordTitleTest.php+8 −8
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectItemsTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectTreeItemsTest.php+1 −1
- typo3/sysext/core/Classes/Information/Typo3Information.php+1 −1
- typo3/sysext/core/Classes/Localization/Parser/AbstractXmlParser.php3+1 −1
- typo3/sysext/core/Classes/Localization/Locales.php+6 −9
- typo3/sysext/core/Classes/Localization/LocalizationFactory.php+1 −1
- typo3/sysext/core/Classes/Site/Entity/SiteLanguage.php+1 −6
- typo3/sysext/core/Classes/Upgrades/BackendUserLanguageMigration.phpnew+99 −0
- typo3/sysext/core/Configuration/TCA/be_users.php+1 −1
- typo3/sysext/core/Documentation/Changelog/14.2/Important-108783-BackendUserLanguageDefaultChangedToEn.rst2new+35 −0
- typo3/sysext/core/Tests/Functional/Localization/LanguageServiceTest.php+7 −7
Show 26 more files
- typo3/sysext/core/Tests/Functional/Utility/File/ExtendedFileUtilityTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Localization/LocalesTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Site/Entity/SiteLanguageTest.php+1 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Validation/ActionControllerValidationTest.php+3 −3
- typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php+1 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Be/PageRendererViewHelperTest.php+2 −2
- typo3/sysext/form/Classes/Service/TranslationService.php+1 −1
- typo3/sysext/form/Tests/Functional/Mvc/Validation/CountValidatorTest.php+1 −1
- typo3/sysext/form/Tests/Functional/Mvc/Validation/DateRangeValidatorTest.php+1 −1
- typo3/sysext/form/Tests/Functional/Mvc/Validation/EmptyValidatorTest.php+1 −1
- typo3/sysext/form/Tests/Functional/Mvc/Validation/FileSizeValidatorTest.php+1 −1
- typo3/sysext/form/Tests/Functional/Mvc/Validation/MimeTypeValidatorTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/Aspect/FileMetadataOverlayAspectTest.php+1 −1
- typo3/sysext/install/Classes/Command/PasswordSetCommand.php+1 −1
- typo3/sysext/install/Classes/Controller/SettingsController.php+1 −1
- typo3/sysext/install/Classes/Service/LanguagePackService.php2+4 −9
- typo3/sysext/linkvalidator/Classes/Result/LinkAnalyzerResult.php+1 −1
- typo3/sysext/linkvalidator/Tests/Functional/LinkAnalyzerTest.php+1 −1
- typo3/sysext/lowlevel/Tests/Functional/Controller/QuerySearchControllerTest.php+1 −1
- typo3/sysext/reactions/Tests/Functional/Reaction/CreateRecordReactionTest.php+1 −1
- typo3/sysext/redirects/Classes/Command/CleanupRedirectsCommand.php+1 −1
- typo3/sysext/scheduler/Classes/Command/SchedulerExecuteCommand.php+1 −1
- typo3/sysext/scheduler/Classes/Command/SchedulerListCommand.php+1 −1
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php2+4 −4
- typo3/sysext/workspaces/Classes/Middleware/WorkspacePreview.php+1 −1
- typo3/sysext/workspaces/Classes/Notification/StageChangeNotification.php+1 −1
Review log 2736
Show 711 earlier messages
-
Benni Mack uploaded patch set 1 01/26/26, 21:01
-
core-ci voted on patch set 1 V +1 01/26/26, 21:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94380
-
Benni Mack marked it ready for review 01/27/26, 09:01
-
Benni Mack rebased onto patch set 2
V +101/27/26, 09:01 -
core-ci voted on patch set 2 V +1 01/27/26, 09:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94401
-
Benni Mack commented on patch set 3
V +101/27/26, 11:15Published edit on patch set 2. -
Benni Mack uploaded patch set 4 01/27/26, 11:17
-
Benni Mack commented on patch set 5 01/27/26, 11:18
Published edit on patch set 4. -
Ayke Halder commented on patch set 2 CR +1 01/27/26, 11:27
In general this looks good - but didn't run the actual code. I'll do that later.Important-108783-BackendUserLanguageDefaultChangedToEn.rst:33We might want to keep `default/base` as "internal core logic" and thereby also keep the actual `default` in "TypoScript overrides" in the future - depending on the decision whether or not the internal fallback is changed to e.g.: * de -> default instead of current * de -> en -> default So maybe keep the wording here more open by just dropping the reference to "TypoScript overrides": ```suggestion * In general: Code that uses `default` as a language key will continue to work as `default` is still mapped to `en` internally. ``` -
core-ci voted on patch set 3 V +1 01/27/26, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94422
-
core-ci voted on patch set 4 V +1 01/27/26, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94423
-
core-ci voted on patch set 5 V +1 01/27/26, 11:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94424
-
Garvin Hicking commented on patch set 5 V -1 01/27/26, 11:47
User settings show: The selected language "English" is not available before the language files are installed. You can use "Manage Language Packs" in the Maintenance module to easily download new language files. when switching a user language to 'english'; and 'english' cannot be picked as a maintenance language. -
Garvin Hicking commented on patch set 5 01/27/26, 12:08
More places to address: - "Hand in the locale to load, or english ("default")." in LocalizationFactory.php - SiteLanguage.php->getTypo3Language() probably needs to stay with 'default' for now - TranslateViewHelper also uses 'default' for languageKey description - Several instances where we may want to change languageServiceFactory->create('default') to 'en': - CreateBackendUserCommand->getBackendUserPasswordValidationErrors - DebugBackendModulesCommand -> languageServiceFactory->create('en') - AbstractformEngineAjaxController->getLabelsFromLocalizationFile() - Typo3Information constructor - PasswordSetCommand - SettingsController->extensionConfigurationGetContentAction - CleanupRedirectsCommand - SchedulerExecuteCommand, SchedulerListCommand - SetupModuleController->renderLanguageSelect() [this one might be worth verifying with a fresh install too) - Middleware/WorkspacePreview - AbstractXmlParser->_getParsedData - languageKey handle 'default|en'? - XliffParser->doParsingFromRoot() - also 'default/en'? - Form/Service/TranslationService.php->setLanguageKeys() - LinkAnalyzerResult->processBrokenLinks (languageCode) (yes, I went through every "default" and 'default' search result. yes, there are lots.) -
Garvin Hicking commented on patch set 5 02/04/26, 18:23
Reply
This now happened in main already. Switching my user language to gernan and back to english "fixed" it. This is beyond the scope of this patch now I guess. -
Ayke Halder commented on patch set 5 02/06/26, 14:36
SetupModuleController.php:711This part of the condition is always `true`. ```suggestion if ($currentSelectedLanguage !== 'en' && !@is_dir(Environment::getLabelsPath() . '/' . $currentSelectedLanguage)) { ``` Either: Change this to `en` to allow for english langauge, even in case the english langauge package is still missing. --> English can always fall back to common/base without the need of the english language package. Or: Remove the check `… !== 'default'` and always give an error if the english language package is not installed. -
Ayke Halder commented on patch set 5 02/06/26, 14:41
LanguagePackService.php:96Just completely drop this. Also there must not be an exemption for `en` here, as also the english language package needs updates. -
Ayke Halder commented on patch set 5 02/06/26, 15:04
LanguagePackService.php:96ReplyOkay, this exemption must stay. English has no language packages right now, as the english language files are provided by the extensions and not by the translation team. Maybe this can become a future feature: * The extension author provides common/base english. * The translation team provides a proper translation for the english language. -
Ayke Halder commented on patch set 6
V +102/06/26, 15:13Published edit on patch set 5. -
Ayke Halder commented on patch set 6 02/06/26, 15:14
SetupModuleController.php:711ReplyFix applied. -
core-ci voted on patch set 6 V +1 02/06/26, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95303
-
Benni Mack uploaded patch set 7
V +102/07/26, 08:04 -
Benni Mack uploaded patch set 8 02/07/26, 08:07
-
Benni Mack commented on patch set 8 02/07/26, 08:07
This change is ready for review.Reply
I adapted the places that made sense.Important-108783-BackendUserLanguageDefaultChangedToEn.rst:33ReplyDone -
core-ci voted on patch set 7 V -1 02/07/26, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95371
-
core-ci voted on patch set 8 V -1 02/07/26, 08:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95372
-
Benni Mack uploaded patch set 9
V -102/08/26, 09:50 -
core-ci voted on patch set 9 V +1 02/08/26, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95403
-
Ayke Halder commented on patch set 9 02/09/26, 09:20
AbstractXmlParser.php:84IMO this needs some further investigation. -
Benni Mack commented on patch set 9 02/09/26, 09:55
AbstractXmlParser.php:84Replythis isn't in active use anymore -
Ayke Halder commented on patch set 9 02/09/26, 09:57
AbstractXmlParser.php:84ReplyAcknowledged -
Ayke Halder voted on patch set 9 CR +1 V +1 02/09/26, 21:11
-
Oliver Klee voted on patch set 9 V +1 02/09/26, 23:53
-
Anja Leichsenring voted on patch set 9 CR +1 V +1 02/11/26, 19:56
-
Benni Mack voted on patch set 9 CR +2 V +2 02/11/26, 19:57
-
Benni Mack merged patch set 10 02/11/26, 19:57