Review main Merged

92534[BUGFIX] Respect TCA default values for select fields in schema analyzer

Benni Mack CR +2 V +2 Normal +105 −6 updated 01/27/26, 11:15

Commit message

The database schema analyzer (DefaultTcaSchema) was using hardcoded
default values (0 for integers, '' for strings) for select fields
instead of respecting the 'default' value defined in TCA.

This change updates the analyzer to use $fieldType->getDefaultValue()
with appropriate fallbacks for select fields, following the same
pattern already used for checkbox fields.

For be_users.lang, the TCA now includes dbFieldLength so the analyzer
creates the correct VARCHAR(10) column, allowing removal of the manual
definition from ext_tables.sql.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1215

  1. Benni Mack uploaded patch set 1 01/27/26, 10:07

  2. Benni Mack marked it ready for review 01/27/26, 10:24

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 01/27/26, 10:30

  4. core-ci voted on patch set 1 V +1 01/27/26, 10:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94416

  5. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 01/27/26, 10:51

  6. Benni Mack commented on patch set 2 01/27/26, 10:51

    Hey @garvin@hick.ing the patch does not fix all of the issues.
  7. Garvin Hicking commented on patch set 2 01/27/26, 10:52

    Sorry for cashing the vote, didn't see it. I added https://forge.typo3.org/issues/108741#change-560436 as a duplicate and Resolves: line.
  8. Garvin Hicking updated the commit message in patch set 3 01/27/26, 10:53

  9. Garvin Hicking voted on patch set 3 CR +1 V +1 01/27/26, 10:54

  10. Garvin Hicking commented on patch set 3 01/27/26, 10:54

    Reply

    Thx. Changed to "Related:" then.
  11. core-ci voted on patch set 2 V +1 01/27/26, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94420

  12. core-ci voted on patch set 3 V +1 01/27/26, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94421

  13. Stefan Bürk voted on patch set 3 CR +1 V +1 01/27/26, 11:12

  14. Benni Mack voted on patch set 3 CR +2 V +2 01/27/26, 11:15

  15. Benni Mack merged patch set 4 01/27/26, 11:15