92536[TASK] Improve localization cache warmup performance
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Ayke Halder +1
-
Verified V +2 Done
- Benni Mack +2
- Garvin Hicking +1
- Ayke Halder +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1318
-
Benni Mack uploaded patch set 1 01/27/26, 12:42
-
core-ci voted on patch set 1 V +1 01/27/26, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94426
-
Ayke Halder commented on patch set 1 01/27/26, 14:12
LocalizationFactory.php:223AFAIK there might be different values for `$fileReference` ultimately resulting in the same real file to be included. Not sure if this gives a huge performance improvement here. Ideally the cache entry is set after resolving the actual file/unique reference to be loaded. E.g. `$actualSourcePath` is resolved in `addFileReferenceToTranslator()` - and a cache entry for the filename-locale-domain is already created there. -
Ayke Halder commented on patch set 1 01/27/26, 14:18
LocalizationFactory.php:223ReplyJust checked it - and I don't see any improvements with `localization-factory-loaded` cache implemented here as there is a proper cache implemented in `addFileReferenceToTranslator()`. The filesystem is pretty fast on checking for (non-existing) files, as these calls to the filesystem are cached in memory - so no disk read operation needed on calling this multiple times for the same file. -
Ayke Halder uploaded patch set 2
V +101/27/26, 15:33 -
core-ci voted on patch set 2 V -1 01/27/26, 15:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94433
-
Ayke Halder uploaded patch set 3
V -101/27/26, 17:01 -
Ayke Halder commented on patch set 3 CR +1 V +1 01/27/26, 17:06
Voting on the code implemented by @benni@typo3.orgLocalizationFactory.php:127ReplyDoneLocalizationFactory.php:223ReplyLet's keep this additional cache as it is a clean solution to not load files twice. -
Ayke Halder uploaded patch set 4
CR +1V +101/27/26, 17:10 -
core-ci voted on patch set 3 V +1 01/27/26, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94443
-
core-ci voted on patch set 4 V +1 01/27/26, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94444
-
Benni Mack updated the commit message in patch set 5
V +101/27/26, 19:27 -
Benni Mack marked it ready for review 01/27/26, 19:27
-
core-ci voted on patch set 5 V +1 01/27/26, 19:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94446
-
Ayke Halder voted on patch set 5 CR +1 V +1 01/28/26, 08:24
-
Garvin Hicking voted on patch set 5 CR +1 V +1 01/28/26, 12:51
-
Benni Mack voted on patch set 5 CR +2 V +2 01/29/26, 08:55
-
Benni Mack merged patch set 6 01/29/26, 08:55
LocalizationFactory.php:127