Review main Abandoned

92537[BUGFIX] Simplify resource selection logic by removing extension matcher

HOJA M A CR 0 V 0 Easy +10 −16 updated 01/27/26, 16:53

Commit message

The resourceSelectableMatcher previously used an AndMatcher to combine a file
extension check (ResourceFileExtensionMatcher) with a custom event-based check.

The extension-based filtering is now being handled elsewhere or is intended to be
encapsulated within the IsFileSelectableEvent listeners. This change simplifies
the matcher initialization by removing the AndMatcher and the explicit extension
filter dependency.

* Removed AndMatcher
* Removed ResourceFileExtensionMatcher
* Kept the anonymous class implementation for IsFileSelectableEvent

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 1

Review log 36

  1. HOJA M A uploaded patch set 1 01/27/26, 15:05

  2. HOJA M A rebased onto patch set 2 01/27/26, 15:07

  3. core-ci voted on patch set 1 V +1 01/27/26, 15:14 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 2 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94430

  4. core-ci voted on patch set 2 V -1 01/27/26, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94431

  5. core-ci voted on patch set 2 V +1 01/27/26, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94431

  6. HOJA M A abandoned the change 01/27/26, 16:53

    Updated old patch by amending this