92540[BUGFIX] Detect DOUBLE/FLOAT precision changes in schema analyzer
Commit message
Review
-
Code review CR -1
- Stefan Bürk -1
-
Verified V -1
- core-ci -1 CI
Issues 1
Files 2
Review log 911
-
Benni Mack uploaded patch set 1 01/27/26, 20:11
-
core-ci voted on patch set 1 V -1 01/27/26, 20:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94447
-
Benni Mack marked it ready for review 04/21/26, 08:03
-
Benni Mack rebased onto patch set 2
V -104/21/26, 08:03 -
core-ci voted on patch set 2 V -1 04/21/26, 08:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100626
-
Stefan Bürk commented on patch set 2 04/21/26, 21:34
I'm going to look into this the next couple of days. TBH I dislike this approach from reading through it because it works against (my) general approach to reduce extended and overriden `Doctrine DBAL` classes and already removed quite some stoff from the comparator. `Doctrine DBAL` moved to pure column declarion sql string comparision stating that this is the right level for the comparison. If that does not really work out we need to look this up upstream in doctrine so the comparision works as expected for the concrete used database. If that is not possible, we should look into providing custon `FloatType` and `DecimalType` implementations providing the correct output. If that is also not possible, we would be on "platform level" - which I'm also working towards get the xclasse's of them out of TYPO3. Not looked into this yet, but going to look into this to find a better way than going back to old overrides. @benni@typo3.org okay for you to put this back to `WIP` ? Putting now a -1 on it. -
Stefan Bürk voted on patch set 2 CR -1 04/21/26, 21:35
-
Benni Mack commented on patch set 2 09/01/26, 16:32
Reply
should we abandon this change? -
Stefan Bürk commented on patch set 2 09/01/26, 20:43
Reply Unresolved
I'm going to look into this - I have changes regarding the metadata and all anyway in the pipeline, possible I find a better way increasing custom stuff in the comparator and working in the other direction I strive to do here in that area. I hope I find a better place/approach for it. -
Benni Mack marked it work in progress 09/11/26, 22:27
-
Benni Mack abandoned the change 10/02/26, 15:40
abandoned