Review main Abandoned

92555[BUGFIX] Fix lighthouse accessbility issue in camino list elements

Markus Timtner CR +1 V +1 Easy +2 −2 updated 04/14/26, 18:41

Commit message

Due to adding a class name to ol and ul, the inner li were wrappend in p-tags.

Review

  • Code review CR +1
    • Georg Ringer +1
    • Simon Schaufelberger +1
  • Verified V +1
    • Georg Ringer +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 710

  1. Markus Timtner uploaded patch set 1 01/28/26, 14:29

  2. Benjamin Franzke commented on patch set 1 01/28/26, 14:37

    Hi Markus, thanks for taking care!
    Try to write commit messages in imperative present tense, see https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html#:~:text=imperative%20present%20tense Example: > [BUGFIX] Fix lighthouse accessbility issue in camino list elements
    We only list branches where this change needs to be cherry-picked to, once it's merged in `Releases`. As `14.2.0` will be tagged based on `main`, this line can simply be `Releases: main`

    content.typoscript:39

    I guess this space could be removed?
  3. core-ci voted on patch set 1 V +1 01/28/26, 14:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94505

  4. Markus Timtner rebased onto patch set 2 V +1 01/28/26, 14:50

  5. core-ci voted on patch set 2 V +1 01/28/26, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94506

  6. Georg Ringer uploaded patch set 3 V +1 02/06/26, 19:31

  7. Georg Ringer commented on patch set 3 CR +1 V +1 02/06/26, 19:32

    Reply

    Done

    Reply

    Done

    content.typoscript:39 Reply

    Done
  8. core-ci voted on patch set 3 V +1 02/06/26, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95339

  9. Simon Schaufelberger voted on patch set 3 CR +1 V +1 02/12/26, 21:42

  10. Garvin Hicking abandoned the change 04/14/26, 18:41