92573[TASK] Ensure ContentObjectRenderer state contains only scalar values
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php1+8 −2
- typo3/sysext/frontend/Classes/Typolink/LinkResult.php2+49 −1
- typo3/sysext/frontend/Classes/Typolink/LinkResultService.phpnew+57 −0
- typo3/sysext/frontend/Classes/Typolink/LinkResultStateInterface.php3new+29 −0
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+20 −0
- typo3/sysext/frontend/Tests/Functional/Typolink/LinkResultServiceTest.phpnew+194 −0
Review log 2227
Show 12 earlier messages
-
Oliver Hader uploaded patch set 1 01/29/26, 12:58
-
core-ci voted on patch set 1 V +1 01/29/26, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94570
-
Oliver Hader commented on patch set 1 01/29/26, 13:08
This change is ready for review. -
Benni Mack voted on patch set 1 CR +1 01/29/26, 17:25
-
Benni Mack voted on patch set 1 V +1 01/30/26, 16:18
-
Benni Mack commented on patch set 1 01/30/26, 16:19
LinkResult.php:63I would feel better if we just use "new" -
Oliver Hader commented on patch set 1 01/30/26, 16:40
LinkResult.php:63ReplyFine, I'll change that in a few minutes... -
Oliver Hader commented on patch set 1 CR -1 01/30/26, 16:41
On it. I'm also adding a test for the new service... -
Oliver Hader uploaded patch set 2
CR +1V +101/30/26, 17:07 -
Oliver Hader commented on patch set 1 CR -1 01/30/26, 17:07
Reply
Done -
Oliver Hader commented on patch set 2 01/30/26, 17:10
https://review.typo3.org/c/Packages/TYPO3.CMS/+/92594 is now a prerequisite for this patch. I think this array utility might be handy for other occurrences as well. -
core-ci voted on patch set 2 V +1 01/30/26, 17:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94689
-
Oliver Hader rebased onto patch set 3
V +101/30/26, 20:53 -
core-ci voted on patch set 3 V +1 01/30/26, 21:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94709
-
Benni Mack voted on patch set 3 CR +1 V +1 02/01/26, 09:18
-
Oliver Hader rebased onto patch set 4
CR +1V +104/13/26, 14:52 -
Christian Kuhn commented on patch set 4 CR -1 04/13/26, 14:59
on it. -
core-ci voted on patch set 4 V +1 04/13/26, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100086
-
Christian Kuhn commented on patch set 4 CR 0 04/13/26, 15:08
LinkResultStateInterface.php:21let's declare the interface @internal as well: i think we could avoid 'lastTypolinkResult' in v15 altogether without too much hassle, which could eventually obsolete the entire construct altogether again, if no further reasons pop up that make it useful. -
Oliver Hader uploaded patch set 5
V +104/13/26, 15:56 -
Oliver Hader commented on patch set 5 04/13/26, 15:57
LinkResultStateInterface.php:21ReplyDone -
Christian Kuhn commented on patch set 5 CR +1 V +1 04/13/26, 15:57
LinkResultStateInterface.php:21Replythx! -
Benni Mack voted on patch set 5 CR +1 V +1 04/13/26, 15:59
-
core-ci voted on patch set 5 V +1 04/13/26, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100090
-
Oliver Hader voted on patch set 5 CR +2 V +2 04/13/26, 16:24
-
Oliver Hader merged patch set 6 04/13/26, 16:24
-
Ayke Halder commented on patch set 5 04/13/26, 16:39
Unresolved
In general: Might we make use of Symfony components for the `getState` and `fromState` implementation? See https://symfony.com/doc/current/serializer.html#serializing-to-or-from-php-arrays ```php use Symfony\Component\Serializer\Normalizer\DenormalizerInterface; use Symfony\Component\Serializer\Normalizer\NormalizerInterface; class PersonController extends AbstractController { public function index(DenormalizerInterface&NormalizerInterface $serializer): Response { $person = new Person('Jane Doe', 39, false); // use normalize() to convert a PHP object to an array $personArray = $serializer->normalize($person, 'json'); // ...and denormalize() to convert an array back to a PHP object $personCopy = $serializer->denormalize($personArray, Person::class); } } . ```ContentObjectRenderer.php:430UnresolvedIs this still true?