Review main Merged

92577[FEATURE] Introduce web component-based form editor tree

Josua Vogel CR +2 V +2 Nightmare +1997 −628 updated 02/18/26, 11:31

Commit message

This migrates the Form Editor's tree component from the legacy
jQuery-based implementation to modern Web Components using Lit
and the TYPO3 backend tree infrastructure.

User-Facing Improvements:
* Intuitive drag & drop with smooth visual feedback
* Smart validation prevents invalid form structures
* Integrated search toolbar for quick element filtering
* Collapse all functionality for better overview
* Persistent navigation maintains expanded/collapsed states
* Auto-restore selection after tree operations

Technical Implementation:
* FormEditorTree extends backend Tree component
* FormEditorTreeContainer wraps navigation component
* FormEditorTreeToolbar integrates search and collapse controls
* tree-component-adapter bridges tree and ViewModel
* Client-side filtering for instant search results
* Hierarchical tree identifiers for stable node references
* Event-based communication (dnd-update/dnd-change)

Drag & Drop Validation Rules:
* Root element (form) cannot be dragged
* Pages must stay at depth 1 (top-level only)
* Pages cannot be moved inside other elements
* Only composite elements (Grid, Fieldset) accept children
* Proper handling of before/after/inside drop positions

The new architecture provides better maintainability,
extensibility, and a significantly improved user experience
while maintaining full backward compatibility with existing
form definitions.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Sven Liebert +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 27

Show 7 more files

Review log 2943

Show 918 earlier messages
  1. Josua Vogel uploaded patch set 1 01/29/26, 19:16

  2. core-ci voted on patch set 1 V -1 01/29/26, 19:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94596

  3. Josua Vogel uploaded patch set 2 V -1 01/30/26, 15:06

  4. core-ci voted on patch set 2 V -1 01/30/26, 15:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94682

  5. Josua Vogel uploaded patch set 3 V -1 01/30/26, 15:51

  6. core-ci voted on patch set 3 V -1 01/30/26, 15:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94686

  7. Josua Vogel uploaded patch set 4 V -1 01/30/26, 20:13

  8. core-ci voted on patch set 4 V -1 01/30/26, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94705

  9. Josua Vogel uploaded patch set 5 V -1 01/30/26, 20:25

  10. core-ci voted on patch set 5 V -1 01/30/26, 20:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94706

  11. Josua Vogel uploaded patch set 6 V -1 01/30/26, 20:37

  12. Josua Vogel rebased onto patch set 7 01/30/26, 20:38

  13. core-ci voted on patch set 6 V -1 01/30/26, 20:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94707

  14. core-ci voted on patch set 7 V -1 01/30/26, 20:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94708

  15. Josua Vogel rebased onto patch set 8 V -1 01/31/26, 13:04

  16. core-ci voted on patch set 8 V -1 01/31/26, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94731

  17. Josua Vogel uploaded patch set 9 V -1 02/01/26, 14:44

  18. core-ci voted on patch set 9 V -1 02/01/26, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94765

  1. Josua Vogel uploaded patch set 10 V -1 02/02/26, 07:39

  2. core-ci voted on patch set 10 V +1 02/02/26, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94796

  3. Sven Liebert voted on patch set 10 CR +1 V +1 02/02/26, 15:59

  4. Josua Vogel uploaded patch set 11 CR +1 V +1 02/13/26, 10:01

  5. Georg Ringer commented on patch set 11 02/13/26, 10:04

    this is not a task but really a nice feature! add a rst and earn the credits!
  6. Josua Vogel commented on patch set 11 02/13/26, 10:04

    Reply

    on it 😊
  7. core-ci voted on patch set 11 V +1 02/13/26, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95817

  8. Josua Vogel uploaded patch set 12 V +1 02/13/26, 10:12

  9. core-ci voted on patch set 12 V +1 02/13/26, 10:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95819

  10. Sven Liebert voted on patch set 12 CR +1 V +1 02/13/26, 10:25

  11. Simon Schaufelberger commented on patch set 12 02/14/26, 11:54

    form-editor-tree-events.ts:139

    remove one empty line

    FormEditorController.php:96

    ```suggestion if ($formPersistenceIdentifier === '') { ```
  12. Josua Vogel commented on patch set 13 CR +1 V +1 02/14/26, 12:08

    Published edit on patch set 12.
  13. Josua Vogel commented on patch set 13 02/14/26, 12:08

    FormEditorController.php:96 Reply

    Fix applied.
  14. core-ci voted on patch set 13 V +1 02/14/26, 12:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95889

  15. Josua Vogel commented on patch set 13 02/14/26, 12:18

    form-editor-tree-events.ts:139 Reply

    Done
  16. Sven Liebert voted on patch set 13 CR +1 V +1 02/14/26, 12:56

  17. Garvin Hicking commented on patch set 13 V +1 02/17/26, 14:30

    Very nice. I wish I could offer a CR+1 vote, but I'm afraid I cannot judge this.
  18. Josua Vogel uploaded patch set 14 CR +1 V +1 02/17/26, 18:23

  19. core-ci voted on patch set 14 V +1 02/17/26, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96076

  20. Anja Leichsenring commented on patch set 14 CR +1 V +1 02/17/26, 19:19

    nice one. I am not overly confident in my TS skills, so I would be happy about a CR from one of the experts in this area, but after it works as it should, please go ahead. Problems will reveal itself once this gets merged and used.
  21. Sven Liebert voted on patch set 14 CR +1 V +1 02/17/26, 19:25

  22. Garvin Hicking voted on patch set 14 V +1 02/17/26, 22:00

  23. Benni Mack commented on patch set 14 02/18/26, 11:13

    Modules.php:21

    I suspect we just inherit access here? Or would somebody wants to have the form_manager without having the form_editor?

    Modules.php:34

    I suspect we just inherit access here?
  24. Benni Mack commented on patch set 14 CR +2 V +2 02/18/26, 11:31

    Modules.php:21 Reply

    handled separately.

    Modules.php:34 Reply

    handled separately.
  25. Benni Mack merged patch set 15 02/18/26, 11:31