Review main Merged

92580[BUGFIX] Restrict copied record translations to target site languages

Eric Harrer CR +2 V +2 Normal +160 −5 updated 02/09/26, 18:28

Commit message

When pages are copied, all existing page translations are currently
copied as well, regardless of the language configuration of the target
site. This can lead to page translations that are not usable or
manageable in the destination context.

This change introduces language filtering based on the configured
languages of the site configuration during the copy process. Record
translations are only copied if their language is configured in the
target site resolved from the destination PID. If no target site can be
determined, no translations will be copied.

Tests are being adapted to cover copying translated pages into sites
with limited or partial language configurations.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • André Buchmann +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • André Buchmann +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 2131

Show 36 earlier messages
  1. Eric Harrer uploaded patch set 1 01/29/26, 21:42

  2. core-ci voted on patch set 1 V -1 01/29/26, 21:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94605

  3. Eric Harrer uploaded patch set 2 V -1 01/30/26, 07:40

  4. core-ci voted on patch set 2 V +1 01/30/26, 07:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94630

  5. Eric Harrer updated the commit message in patch set 3 V +1 01/30/26, 08:35

  6. core-ci voted on patch set 3 V +1 01/30/26, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94632

  1. Eric Harrer uploaded patch set 4 V +1 01/30/26, 11:29

  2. core-ci voted on patch set 4 V +1 01/30/26, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94650

  3. Eric Harrer uploaded patch set 5 V +1 01/30/26, 12:07

  4. Eric Harrer updated the commit message in patch set 6 01/30/26, 12:14

  5. core-ci voted on patch set 6 V +1 01/30/26, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94657

  6. André Buchmann voted on patch set 6 CR +1 V +1 01/30/26, 12:34

  7. André Buchmann uploaded patch set 7 CR +1 V +1 01/30/26, 12:40

  8. André Buchmann voted on patch set 7 CR +1 V +1 01/30/26, 12:42

  9. core-ci voted on patch set 5 V +1 01/30/26, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94654

  10. core-ci voted on patch set 7 V +1 01/30/26, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94661

  11. Benni Mack commented on patch set 7 01/30/26, 15:47

    can we add logging for such cases (also the existing one, where we unset the translated records?) I mean, we shouldn't just keep this for ourselves (logging in $dataHandler->log() should be sufficient IMHO)
  12. André Buchmann uploaded patch set 8 CR +1 V +1 01/31/26, 21:06

  13. core-ci voted on patch set 8 V +1 01/31/26, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94736

  14. André Buchmann commented on patch set 8 CR +1 V +1 01/31/26, 21:15

    Reply

    A warning is now logged for both unset() calls.
  15. Garvin Hicking commented on patch set 8 01/31/26, 23:02

    DataHandler.php:4174

    I think the SiteFinder can be injected into DataHandler?
  16. André Buchmann uploaded patch set 9 CR +1 V +1 02/02/26, 08:43

  17. André Buchmann commented on patch set 9 02/02/26, 08:45

    DataHandler.php:4174 Reply

    DI is now used for the SiteFinder
  18. core-ci voted on patch set 9 V -1 02/02/26, 08:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94799

  19. André Buchmann uploaded patch set 10 V -1 02/02/26, 09:18

  20. core-ci voted on patch set 10 V +1 02/02/26, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94804

  21. Benni Mack commented on patch set 10 CR +1 V +1 02/02/26, 09:47

    thank you!
  22. Garvin Hicking voted on patch set 10 CR +1 V +1 02/02/26, 13:23

  23. André Buchmann voted on patch set 10 CR +1 V +1 02/09/26, 17:28

  24. Benni Mack voted on patch set 10 CR +2 V +2 02/09/26, 18:28

  25. Benni Mack merged patch set 11 02/09/26, 18:28