Review main Merged

92581[TASK] Split responsibilities of toolbar search item and live-search

Benjamin Kott CR +2 V +2 Normal +64 −38 updated 01/30/26, 15:13

Commit message

The LiveSearch module was tightly coupled to the topbar by directly
binding click events on the search button. This patch moves it from
toolbar/live-search to live-search/live-search so it only reacts
to the typo3:live-search:trigger-open event. A new toolbar item
module live-search/toolbar/live-search-toolbar-item handles the
click binding and dispatches the event to open the search.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 1013

  1. Benjamin Kott uploaded patch set 1 01/30/26, 07:18

  2. Josef Glatz commented on patch set 1 01/30/26, 07:25

    @benjamin.kott@outlook.com would you like to implement https://review.typo3.org/c/Packages/TYPO3.CMS/+/92505 within your change?
  3. core-ci voted on patch set 1 V +1 01/30/26, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94626

  4. Benjamin Kott commented on patch set 1 CR -1 01/30/26, 08:07

    Reply

    will review the other patch first, as this requires a backport
  5. Benjamin Kott uploaded patch set 2 CR -1 V +1 01/30/26, 12:08

  6. core-ci voted on patch set 2 V +1 01/30/26, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94655

  7. Benjamin Franzke voted on patch set 2 CR +1 V +1 01/30/26, 14:24

  8. Benjamin Kott rebased onto patch set 3 CR +1 V +1 01/30/26, 14:31

  9. Benjamin Franzke voted on patch set 3 CR +1 V +1 01/30/26, 14:36

  10. Andreas Kienast voted on patch set 3 CR +1 V +1 01/30/26, 15:02

  11. core-ci voted on patch set 3 V +1 01/30/26, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94677

  12. Andreas Kienast voted on patch set 3 CR +2 V +2 01/30/26, 15:13

  13. Andreas Kienast merged patch set 4 01/30/26, 15:13