Review 12.4 Merged

92583[BUGFIX] Fix --exclude option in impexp:export command

Garvin Hicking CR +2 V +2 Easy +3 −3 updated 01/31/26, 08:41

Commit message

The --exclude option in the impexp command expects an associative array
with "table:uid" as keys. Symfony console however passes an array
with numeric keys to the export loop, which then throws a type error
and aborts the command.

Convert the CLI input to the expected format to avoid this error.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Garvin Hicking commented on patch set 1 01/30/26, 07:35

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/impexp/Tests/Functional/Command/ExportCommandTest.php
  2. core-ci voted on patch set 1 V -1 01/30/26, 07:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94629

  3. Garvin Hicking uploaded patch set 2 V -1 01/30/26, 07:44

    address merge conflict
  4. core-ci voted on patch set 2 V +1 01/30/26, 07:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94631

  5. Garvin Hicking marked it ready for review 01/30/26, 07:51

  6. Garvin Hicking voted on patch set 2 CR +2 V +2 01/31/26, 08:41

  7. Garvin Hicking merged patch set 3 01/31/26, 08:41