Review main Merged

92584[BUGFIX] Resolve broken hotkey handler binding

Andreas Kienast CR +2 V +2 Hard +236 −75 updated 01/31/26, 18:54

Commit message

Currently the HotkeyStorage is treated as a singleton instance, causing
binding issues in case a registered handler is not available anymore,
e.g. when a `document` (=iframe) is removed from DOM.

The hotkey handling is reworked in several aspects.

First, all documents may have their own instance of the hotkey storage,
solving issues related to local bindings into global space.

Instead of handling the hotkeys directly, the `typo3:hotkey-requested`
event is now dispatched to the top frame. The hotkey negotiator
dispatches the `typo3:hotkey-dispatched` event to all available
documents until a responsible handler is found.

This way, local bindings can be accessed. This also allows us to remove
the duplicated loading of `live-search-shortcut.js` which was a
workaround to have `Ctrl+K` available in the iframe as well.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 1423

  1. Andreas Kienast uploaded patch set 1 01/30/26, 10:35

  2. Andreas Kienast updated the commit message in patch set 2 01/30/26, 10:46

  3. core-ci voted on patch set 1 V +1 01/30/26, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94640

  4. Andreas Kienast uploaded patch set 3 01/30/26, 10:47

  5. core-ci voted on patch set 3 V +1 01/30/26, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94644

  6. Andreas Kienast uploaded patch set 4 V +1 01/30/26, 11:15

  7. core-ci voted on patch set 4 V +1 01/30/26, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94648

  8. core-ci voted on patch set 2 V +1 01/30/26, 11:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94642

  9. Andreas Kienast uploaded patch set 5 V +1 01/30/26, 11:35

  10. core-ci voted on patch set 5 V +1 01/30/26, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94651

  11. Andreas Kienast uploaded patch set 6 V +1 01/30/26, 12:01

  12. Andreas Kienast uploaded patch set 7 01/30/26, 12:09

  13. core-ci voted on patch set 6 V +1 01/30/26, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94653

  14. core-ci voted on patch set 7 V +1 01/30/26, 12:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94656

  15. Andreas Kienast uploaded patch set 8 V +1 01/30/26, 13:41

  16. Andreas Kienast uploaded patch set 9 01/30/26, 14:16

  17. core-ci voted on patch set 8 V +1 01/30/26, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94669

  18. Benjamin Franzke voted on patch set 9 CR +1 V +1 01/30/26, 14:22

  19. core-ci voted on patch set 9 V +1 01/30/26, 14:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94672

  20. Benjamin Kott voted on patch set 9 CR +1 V +1 01/30/26, 14:58

  21. Andreas Kienast voted on patch set 9 CR +2 V +2 01/30/26, 14:59

  22. Andreas Kienast merged patch set 10 01/30/26, 15:08

  23. Josef Glatz commented on patch set 10 01/31/26, 18:54

    thank you!