Review main Abandoned

92585[BUGFIX] Show free-mode content if default column is empty

Eric Harrer CR +1 V +1 Normal +177 −0 updated 08/07/26, 21:29

Commit message

In the Page/Layout module’s Language Comparison mode, free-mode content
elements (l18n_parent = 0) in non-default languages were not rendered
when the default language column contained no records.

This change adds a fallback rendering case to ensure free-mode content
is displayed correctly in that situation.

The fix aligns with the v14 default-language binding behavior and adds
a functional regression test based on a YAML scenario fixture.

Review

  • Code review CR +1
    • André Buchmann +1
  • Verified V +1
    • Bastien Lutz +1
    • André Buchmann +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1521

  1. Eric Harrer uploaded patch set 1 01/30/26, 10:44

  2. Eric Harrer updated the commit message in patch set 2 01/30/26, 10:47

  3. core-ci voted on patch set 2 V -1 01/30/26, 11:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94643

  4. core-ci voted on patch set 1 V -1 01/30/26, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94641

  5. Eric Harrer uploaded patch set 3 V -1 02/06/26, 09:14

  6. core-ci voted on patch set 3 V +1 02/06/26, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95252

  7. Eric Harrer updated the commit message in patch set 4 V +1 02/06/26, 09:51

  8. core-ci voted on patch set 4 V +1 02/06/26, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95257

  9. Eric Harrer uploaded patch set 5 V +1 02/06/26, 12:02

  10. André Buchmann voted on patch set 5 CR +1 V +1 02/06/26, 12:03

  11. core-ci voted on patch set 5 V +1 02/06/26, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95277

  12. Benni Mack commented on patch set 5 02/26/26, 09:54

    just by reading the code: How do we handle sorting then? I think we should just document this in the commit message.
  13. Eric Harrer commented on patch set 5 03/06/26, 11:47

    Reply

    Since we only corrected the visibility of free mode contentelements in the layout module and did not change the final grid rendering, the patch has no effect on sorting. See screenshot on forge: https://forge.typo3.org/issues/108809#note-7
  14. Riccardo De Contardi commented on patch set 5 V +1 03/23/26, 14:15

    verified the visibility of the elements
  15. Benni Mack wrote 04/21/26, 14:53

    Removed cc Benni Mack.
  16. Benni Mack updated the commit message in patch set 6 CR +1 V +1 04/22/26, 07:20

  17. Eric Harrer rebased onto patch set 7 04/23/26, 10:50

  18. core-ci voted on patch set 7 V +1 04/23/26, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101030

  19. André Buchmann voted on patch set 7 CR +1 V +1 04/23/26, 20:52

  20. Bastien Lutz voted on patch set 7 V +1 08/04/26, 08:08

  21. Eric Harrer abandoned the change 08/07/26, 21:29

    Abandoned as this was further developed in https://review.typo3.org/c/Packages/TYPO3.CMS/+/95170