Review 13.4 Merged

92591[BUGFIX] Resolve broken hotkey handler binding

Andreas Kienast CR +2 V +2 Hard +236 −75 updated 01/30/26, 15:08

Commit message

Currently the HotkeyStorage is treated as a singleton instance, causing
binding issues in case a registered handler is not available anymore,
e.g. when a `document` (=iframe) is removed from DOM.

The hotkey handling is reworked in several aspects.

First, all documents may have their own instance of the hotkey storage,
solving issues related to local bindings into global space.

Instead of handling the hotkeys directly, the `typo3:hotkey-requested`
event is now dispatched to the top frame. The hotkey negotiator
dispatches the `typo3:hotkey-dispatched` event to all available
documents until a responsible handler is found.

This way, local bindings can be accessed. This also allows us to remove
the duplicated loading of `live-search-shortcut.js` which was a
workaround to have `Ctrl+K` available in the iframe as well.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 16

Review log 45

  1. Andreas Kienast uploaded patch set 1 01/30/26, 15:00

  2. core-ci voted on patch set 1 V +1 01/30/26, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94681

  3. Andreas Kienast voted on patch set 1 V +2 01/30/26, 15:07

  4. Andreas Kienast voted on patch set 1 CR +2 01/30/26, 15:08

  5. Andreas Kienast merged patch set 2 01/30/26, 15:08