Review 13.4 Merged

92593[BUGFIX] Prevent evaluating hidden TypoScript in backend modules

Garvin Hicking CR +2 V +2 Normal +205 −13 updated 02/09/26, 17:58

Commit message

The `SysTemplateRepository` fetches database records from sys_template
by checking the visibility context aspect. In the backend module,
this is set to 'includeHiddenContent: true' by default (greedy backend),
so that hidden records (or those with time restrictions) can always be
revealed.

This is important to be able to edit/modify the `sys_template` records,
and to enable/disable them, or put starttime/endtime on them.

But, hidden records should NOT be evaluated inside the modules:

* Active TypoScript
* Included TypoScript
* Constant Editor

In the context of these controllers, the visibility aspect is now
changed to 'includeHiddenContent: false' plus
'includeScheduledRecords: false'. Since this is done in three
controllers dealing with simulation, that assignment is done
in the `AbstractTemplateModuleController`, and called from
the specific three instances.

Tests are added to verify that the `SysTemplateRepository` properly
evaluates the contexts.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 2

Files 9

Review log 58

  1. Garvin Hicking commented on patch set 1 01/30/26, 16:17

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 01/30/26, 16:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94688

  3. Garvin Hicking commented on patch set 2 V +1 02/09/26, 05:52

    Cherry Picked from branch main.
  4. core-ci voted on patch set 2 V +1 02/09/26, 05:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95434

  5. Garvin Hicking commented on patch set 3 V +1 02/09/26, 17:28

    Cherry Picked from branch main.
  6. core-ci voted on patch set 3 V +1 02/09/26, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95479

  7. Garvin Hicking voted on patch set 3 CR +2 V +2 02/09/26, 17:57

  8. Garvin Hicking merged patch set 4 02/09/26, 17:58