Review main Merged

92612[FEATURE] Extract field rendering helpers into dedicated service

Benni Mack CR +2 V +2 Expert +1485 −320 updated 02/03/26, 10:24

Commit message

This change extracts auxiliary rendering methods from
StandardContentPreviewRenderer into a new RecordFieldRenderer
service class. This allows custom preview renderers to use
these helpers without extending StandardContentPreviewRenderer.

RecordFieldRenderer provides methods for rendering:
* Simple fields (in the header) with edit links
* Truncated text fields
* File references with thumbnails
* Labeled field values from TCA / Schema

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1522

  1. Benni Mack uploaded patch set 1 01/31/26, 15:09

  2. core-ci voted on patch set 1 V -1 01/31/26, 15:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94732

  3. Benni Mack uploaded patch set 2 V -1 01/31/26, 17:43

  4. core-ci voted on patch set 2 V -1 01/31/26, 17:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94733

  5. Benni Mack uploaded patch set 3 V -1 01/31/26, 20:31

  6. core-ci voted on patch set 3 V -1 01/31/26, 20:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94734

  7. Benni Mack uploaded patch set 4 V -1 02/01/26, 08:55

  8. core-ci voted on patch set 4 V -1 02/01/26, 09:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94751

  9. Benni Mack uploaded patch set 5 V -1 02/01/26, 09:16

  10. core-ci voted on patch set 5 V -1 02/01/26, 09:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94752

  11. Benni Mack uploaded patch set 6 V -1 02/01/26, 09:28

  12. Benni Mack marked it ready for review 02/01/26, 09:28

  13. core-ci voted on patch set 6 V -1 02/01/26, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94753

  14. Benni Mack uploaded patch set 7 V -1 02/01/26, 10:39

  15. core-ci voted on patch set 7 V +1 02/01/26, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94757

  16. Anja Leichsenring voted on patch set 7 CR +1 V +1 02/01/26, 11:23

  17. Georg Ringer voted on patch set 7 CR +2 V +2 02/01/26, 12:38

  18. Georg Ringer merged patch set 8 02/01/26, 12:38

  19. Benjamin Franzke commented on patch set 8 02/03/26, 08:02

    Hi, with this patch I receive a `TypeError` when opening the "Layout" module on a page that contains a content element with the `date` field set to a value. ``` (1/1) TypeError TYPO3\CMS\Core\Domain\DateTimeFactory::createFomDatabaseValueAndTCAConfig(): Argument #1 ($value) must be of type string|int|null, DateTimeImmutable given, called in /var/www/html/TYPO3.CMS/typo3/sysext/backend/Classes/Utility/BackendUtility.php on line 1726 ``` This would be implicitly fixed by the following patch: > 86925: [TASK] Transform all dates in DatabaseRowDateTimeFields to DateTime | https://review.typo3.org/c/Packages/TYPO3.CMS/+/86925 with the fix in: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86925/33/typo3/sysext/backend/Classes/Utility/BackendUtility.php …but I'm not sure, should we first push a separate BUGFIX?
  20. Benjamin Franzke commented on patch set 8 02/03/26, 09:20

    StandardContentPreviewRenderer.php:80

    stripping tags does not remove/replace entities, which means this would end up with something like: > Date 1970-01-01
  21. Benni Mack commented on patch set 8 02/03/26, 10:20

    StandardContentPreviewRenderer.php:80 Reply

    Hey, I will push a bugfix.
  22. Benni Mack commented on patch set 8 02/03/26, 10:24

    StandardContentPreviewRenderer.php:80 Reply