92612[FEATURE] Extract field rendering helpers into dedicated service
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Georg Ringer +2
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/backend/Classes/Preview/RecordFieldPreviewProcessor.phpnew+232 −0
- typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php3+65 −131
- typo3/sysext/backend/Tests/Functional/Preview/Fixtures/Folders/fileadmin/user_upload/ThumnailViewHelperFalTest.jpgnewbinary
- typo3/sysext/backend/Tests/Functional/Preview/Fixtures/CustomPreviewRendererFixture.phpnew+47 −0
- typo3/sysext/backend/Tests/Functional/Preview/Fixtures/fal_files.csvnew+29 −0
- typo3/sysext/backend/Tests/Functional/Preview/Fixtures/xss_content.csvnew+14 −0
- typo3/sysext/backend/Tests/Functional/Preview/RecordFieldPreviewProcessorTest.phpnew+388 −0
- typo3/sysext/backend/Tests/Functional/Preview/StandardPreviewRendererResolverTest.phpnew+117 −0
- typo3/sysext/backend/Tests/Unit/Preview/RecordFieldPreviewProcessorTest.phpnew+470 −0
- typo3/sysext/backend/Tests/Unit/Preview/StandardPreviewRendererResolverTest.phpdeleted+0 −173
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-108819-RecordFieldPreviewProcessorForCustomPreviewRenderers.rstnew+111 −0
- typo3/sysext/form/Classes/Hooks/FormPagePreviewRenderer.php+12 −16
Review log 1522
-
Benni Mack uploaded patch set 1 01/31/26, 15:09
-
core-ci voted on patch set 1 V -1 01/31/26, 15:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94732
-
Benni Mack uploaded patch set 2
V -101/31/26, 17:43 -
core-ci voted on patch set 2 V -1 01/31/26, 17:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94733
-
Benni Mack uploaded patch set 3
V -101/31/26, 20:31 -
core-ci voted on patch set 3 V -1 01/31/26, 20:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94734
-
Benni Mack uploaded patch set 4
V -102/01/26, 08:55 -
core-ci voted on patch set 4 V -1 02/01/26, 09:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94751
-
Benni Mack uploaded patch set 5
V -102/01/26, 09:16 -
core-ci voted on patch set 5 V -1 02/01/26, 09:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94752
-
Benni Mack uploaded patch set 6
V -102/01/26, 09:28 -
Benni Mack marked it ready for review 02/01/26, 09:28
-
core-ci voted on patch set 6 V -1 02/01/26, 10:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94753
-
Benni Mack uploaded patch set 7
V -102/01/26, 10:39 -
core-ci voted on patch set 7 V +1 02/01/26, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94757
-
Anja Leichsenring voted on patch set 7 CR +1 V +1 02/01/26, 11:23
-
Georg Ringer voted on patch set 7 CR +2 V +2 02/01/26, 12:38
-
Georg Ringer merged patch set 8 02/01/26, 12:38
-
Benjamin Franzke commented on patch set 8 02/03/26, 08:02
Hi, with this patch I receive a `TypeError` when opening the "Layout" module on a page that contains a content element with the `date` field set to a value. ``` (1/1) TypeError TYPO3\CMS\Core\Domain\DateTimeFactory::createFomDatabaseValueAndTCAConfig(): Argument #1 ($value) must be of type string|int|null, DateTimeImmutable given, called in /var/www/html/TYPO3.CMS/typo3/sysext/backend/Classes/Utility/BackendUtility.php on line 1726 ``` This would be implicitly fixed by the following patch: > 86925: [TASK] Transform all dates in DatabaseRowDateTimeFields to DateTime | https://review.typo3.org/c/Packages/TYPO3.CMS/+/86925 with the fix in: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86925/33/typo3/sysext/backend/Classes/Utility/BackendUtility.php …but I'm not sure, should we first push a separate BUGFIX? -
Benjamin Franzke commented on patch set 8 02/03/26, 09:20
StandardContentPreviewRenderer.php:80stripping tags does not remove/replace entities, which means this would end up with something like: > Date 1970-01-01 -
Benni Mack commented on patch set 8 02/03/26, 10:20
StandardContentPreviewRenderer.php:80ReplyHey, I will push a bugfix. -
Benni Mack commented on patch set 8 02/03/26, 10:24
StandardContentPreviewRenderer.php:80Reply