Review main Merged

92619[TASK] Increase test coverage for template path overrides

Simon Praetorius CR +2 V +2 Normal +111 −0 updated 02/01/26, 19:36

Commit message

Issue #108779 uncovered potential issues in the way template paths
are merged. As a first step, this patch increases test coverage in the
relevant area (`TemplatePaths` class).

The new test cases suggest two separate issues, one in Extbase and
one in Fluid. Both concern the way template paths are interpreted
if one path is specified multiple times in the same array. From a
user's point of view, this would suggest that the "higher ordered"
path should be used, however TYPO3 (and Fluid) uses the "lower ordered"
path.

These actual issues can be tackled in follow-up patches both in TYPO3
and Fluid Standalone. For now, they are documented as `@todo` in
the newly added test cases.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 3

Files 3

Review log 710

  1. Simon Praetorius uploaded patch set 1 02/01/26, 17:30

  2. Simon Praetorius updated the commit message in patch set 2 02/01/26, 17:33

  3. core-ci voted on patch set 1 V +1 02/01/26, 17:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94772

  4. core-ci voted on patch set 2 V +1 02/01/26, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94773

  5. Simon Praetorius updated the commit message in patch set 3 V +1 02/01/26, 18:03

  6. core-ci voted on patch set 3 V +1 02/01/26, 18:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94777

  7. Garvin Hicking voted on patch set 3 CR +1 V +1 02/01/26, 18:16

  8. Anja Leichsenring voted on patch set 3 CR +1 V +1 02/01/26, 19:29

  9. Simon Praetorius voted on patch set 3 CR +2 V +2 02/01/26, 19:36

  10. Simon Praetorius merged patch set 4 02/01/26, 19:36