92625[TASK] Remove usage of alpine image in `runTests.sh`
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Garvin Hicking +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1725
-
Oliver Klee uploaded patch set 1 02/02/26, 17:34
-
Garvin Hicking updated the commit message in patch set 2 02/02/26, 17:56
-
Garvin Hicking commented on patch set 2 02/02/26, 17:56
This needs to be pulled on the CI machines so we need Stefan/Lolli to take on this. -
core-ci voted on patch set 2 V -1 02/02/26, 18:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94839
-
core-ci voted on patch set 1 V -1 02/02/26, 18:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94834
-
Oliver Klee uploaded patch set 3
V -102/02/26, 18:23 -
core-ci voted on patch set 3 V -1 02/02/26, 18:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94841
-
Andreas Kienast commented on patch set 3 02/03/26, 07:02
Do you have changelogs at hand that verify this statement? -
Oliver Klee rebased onto patch set 4
V -102/03/26, 09:36 -
Oliver Klee commented on patch set 4 02/03/26, 09:38
Reply
Quite a lot of versions have been released between version 3.8 and 3.23. I've linked the two pages with release notes and reworded the commit message to focus on the old release being EOL instead of listing specific types of changes now. -
core-ci voted on patch set 4 V -1 02/03/26, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94880
-
Stefan Bürk commented on patch set 4 02/07/26, 18:25
You can try to use other versions as long as you want, won't work. Image (versions) needs to be pre-pulled on the CI runner and is one security barrier to avoid that any contributor could simply pull and start any image on our public available CI infrastructure, for example some kind of miner (bitcoint and similar). I'm thinking simply reusing the core-testing image instead of the alpine image for simple start up tasks .. does not hurt to reuse the same image and drop the need for a raw alpine image I guess. But need to check the usage in runTests.sh first. If staying on it I'm going to have a look which version to use and going to add the image version to our infrastructure pull script(s). -
Stefan Bürk uploaded patch set 5
V -103/05/26, 14:29 -
core-ci voted on patch set 5 V +1 03/05/26, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97412
-
Stefan Bürk commented on patch set 5 03/05/26, 14:43
Reply
Reworked the change to drop the alpine image and use the core-testing-phpXY image instead. -
Stefan Bürk updated the commit message in patch set 6
V +103/05/26, 14:44 -
Oliver Klee voted on patch set 6 CR +1 V +1 03/05/26, 14:45
-
Oliver Klee updated the commit message in patch set 7
CR +1V +103/05/26, 14:46 -
Oliver Klee voted on patch set 7 CR +1 V +1 03/05/26, 14:46
-
core-ci voted on patch set 6 V +1 03/05/26, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97414
-
core-ci voted on patch set 7 V +1 03/05/26, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97415
-
core-ci voted on patch set 5 V +1 03/05/26, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97413
-
Garvin Hicking voted on patch set 7 CR +1 V +1 03/05/26, 16:01
-
Stefan Bürk voted on patch set 7 CR +2 V +2 03/05/26, 17:19
-
Stefan Bürk merged patch set 8 03/05/26, 17:34