Review main Merged

92627[TASK] Update to typo3-documentation/render-guides 0.37

Oliver Klee CR +2 V +2 Easy +1 −1 updated 04/27/26, 07:07

Commit message

This version brings a couple of bugfixes for rendering the
documentation.

https://github.com/TYPO3-Documentation/render-guides/releases/tag/0.36.0
https://github.com/TYPO3-Documentation/render-guides/releases/tag/0.37.0

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1825

  1. Oliver Klee uploaded patch set 1 02/02/26, 17:37

  2. core-ci voted on patch set 1 V -1 02/02/26, 17:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94836

  3. Oliver Klee uploaded patch set 2 V -1 02/02/26, 17:54

  4. core-ci voted on patch set 2 V -1 02/02/26, 18:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94838

  5. Oliver Klee uploaded patch set 3 V -1 02/02/26, 18:22

  6. core-ci voted on patch set 3 V -1 02/02/26, 18:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94840

  7. Stefan Bürk commented on patch set 3 02/07/26, 18:28

    Simply using other image versions does not work, they need to be pre-pulled on the ci runners. See comment on similar change here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/92625/comments/1f40cf79_77bcb946 This needs a confirmation from the documentation team first or the bridge @garvin@hick.ing to raise the version in a coordinated manner. Waiting for feedback on this first before pulling the image on the ci runners.
  8. Garvin Hicking commented on patch set 3 CR +1 V +1 02/07/26, 19:40

    Reply

    I'm good raising the version if its not too much work, yes. Not critical but nice to have the core docs rendered the same as community docs.
  9. Benni Mack updated the commit message in patch set 4 CR +1 V +1 04/22/26, 06:26

  10. core-ci voted on patch set 4 V -1 04/22/26, 07:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100699

  11. Oliver Klee voted on patch set 4 CR +1 V +1 04/22/26, 07:50

  12. Garvin Hicking commented on patch set 4 04/22/26, 11:38

    i think 0.37 is stable, could you update?
  13. Oliver Klee voted on patch set 4 CR 0 V 0 04/22/26, 11:41

  14. Oliver Klee rebased onto patch set 5 V -1 04/22/26, 11:43

  15. Oliver Klee commented on patch set 5 04/22/26, 11:44

    Reply

    Yes, of course. Done.
  16. core-ci voted on patch set 5 V -1 04/22/26, 11:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100894

  17. Garvin Hicking commented on patch set 5 04/22/26, 12:22

    Reply

    @stefan@buerk.tech or @lolli@schwarzbu.ch would have to pull the image on podman please

    runTests.sh:861

    ```suggestion IMAGE_RSTRENDERING="ghcr.io/typo3-documentation/render-guides:0.37" ```
  18. Oliver Klee commented on patch set 5 04/22/26, 12:39

    Ah, missed actually updating the version. Thanks!

    runTests.sh:861 Reply

    Fix applied.
  19. Oliver Klee commented on patch set 6 V -1 04/22/26, 12:39

    Published edit on patch set 5.
  20. core-ci voted on patch set 6 V -1 04/22/26, 12:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100898

  21. Oliver Klee rebased onto patch set 7 V -1 04/27/26, 05:43

  22. core-ci voted on patch set 7 V +1 04/27/26, 05:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101146

  23. Stefan Bürk commented on patch set 7 CR +1 V +1 04/27/26, 05:52

    Reply

    Done

    Reply

    Done
  24. Garvin Hicking voted on patch set 7 CR +2 V +2 04/27/26, 06:26

  25. Garvin Hicking merged patch set 8 04/27/26, 07:07