Review main Merged

92640[BUGFIX] Adds aria-label to kebab menus and uses popover API

Riccardo De Contardi CR +2 V +2 Easy +16 −12 updated 10/24/26, 06:51

Commit message

For accessibility purposes:
- the aria-label attribute is added to the buttons
with the "three-dots" (AKA "kebab") icon
- aria-haspopup="menu" is added
Moreover to reduce the dependency from Bootstrap
- anchors are changed to buttons that leverage the popover API

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Rath-Ulrich +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Rath-Ulrich +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1827

Show 12 earlier messages
  1. Riccardo De Contardi uploaded patch set 1 02/03/26, 10:01

  2. core-ci voted on patch set 1 V +1 02/03/26, 10:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94886

  1. Michael Telgkamp commented on patch set 1 CR +1 02/03/26, 10:46

    The current status is, that we do not have accessible tooltips for the TYPO3 backend but use title attributes to add something close to it. So having the `title` attributes there is fine, to have some kind of hint for sighted users. Regarding the buttons: currently 3 of the 4 buttons actually are links, which is not accessible, as the do not link somewhere, but open a menu (as far as I understand). So if they stay to be `<a>` tags, they need to become of `role="button"` and also the keyboard handling (activation on pressing space) needs to be adjusted. The other option would be to change them to `<button type="button"` elements to have the native button behaviour. As the buttons open a menu, it would also be good to include the `aria-haspopup` attribute on the button element. As a reminder: do not use `true` as a value for the attribute, use `menu` instead to make it more understandable. Resource for aria-haspopup: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Attributes/aria-haspopup
  2. Michael Telgkamp voted on patch set 1 CR -1 02/03/26, 10:47

  3. Riccardo De Contardi uploaded patch set 2 CR -1 V +1 02/03/26, 11:01

  4. core-ci voted on patch set 2 V +1 02/03/26, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94891

  5. Riccardo De Contardi uploaded patch set 3 V +1 02/03/26, 11:42

  6. core-ci voted on patch set 3 V +1 02/03/26, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94896

  7. Riccardo De Contardi uploaded patch set 4 V +1 02/03/26, 13:50

  8. core-ci voted on patch set 4 V +1 02/03/26, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94912

  9. Riccardo De Contardi uploaded patch set 5 V +1 02/03/26, 14:07

  10. Riccardo De Contardi updated the commit message in patch set 6 02/03/26, 14:10

  11. Riccardo De Contardi commented on patch set 6 02/03/26, 14:11

    Reply

    I tried to address your remarks
  12. core-ci voted on patch set 6 V +1 02/03/26, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94917

  13. core-ci voted on patch set 5 V +1 02/03/26, 14:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94915

  14. Riccardo De Contardi updated the commit message in patch set 7 V +1 02/04/26, 08:32

  15. core-ci voted on patch set 7 V +1 02/04/26, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94977

  16. Jennifer Geiß voted on patch set 7 CR +1 03/26/26, 08:31

  17. Benni Mack updated the commit message in patch set 8 CR +1 V +1 04/22/26, 07:16

  18. core-ci voted on patch set 8 V -1 04/22/26, 12:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100854

  19. Simon Schaufelberger uploaded patch set 9 V -1 07/10/26, 21:19

  20. core-ci voted on patch set 9 V +1 07/10/26, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104646

  21. Georg Ringer voted on patch set 9 CR +1 V +1 09/01/26, 18:48

  22. Josua Vogel voted on patch set 9 CR +1 10/08/26, 20:55

  23. Christian Rath-Ulrich voted on patch set 9 CR +1 V +1 10/22/26, 14:06

  24. Georg Ringer voted on patch set 9 CR +2 V +2 10/24/26, 06:51

  25. Georg Ringer merged patch set 10 10/24/26, 06:51