Review main Merged

92643[FEATURE] Add Badge for Slide Mode in Layout Module

Matthias Vogel CR +2 V +2 Normal +84 −4 updated 02/04/26, 14:44

Commit message

Editors now have more information about what slideMode is used.
There is also a short description of what it does.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Simon Praetorius +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Simon Praetorius +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 11

Review log 2532

Show 47 earlier messages
  1. Matthias Vogel uploaded patch set 1 02/03/26, 11:47

  2. core-ci voted on patch set 1 V -1 02/03/26, 11:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94897

  3. Matthias Vogel uploaded patch set 2 V -1 02/03/26, 12:51

  4. core-ci voted on patch set 2 V -1 02/03/26, 12:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94900

  5. Matthias Vogel uploaded patch set 3 V -1 02/03/26, 13:07

  6. core-ci voted on patch set 3 V -1 02/03/26, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94902

  7. Matthias Vogel uploaded patch set 4 V -1 02/03/26, 13:26

  1. Matthias Vogel uploaded patch set 5 02/03/26, 13:29

  2. Matthias Vogel uploaded patch set 6 02/03/26, 13:33

  3. core-ci voted on patch set 4 V -1 02/03/26, 13:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94903

  4. core-ci voted on patch set 5 V +1 02/03/26, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94904

  5. core-ci voted on patch set 6 V +1 02/03/26, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94907

  6. Benni Mack voted on patch set 6 CR +1 V +1 02/03/26, 14:22

  7. Oliver Hader voted on patch set 6 CR +1 02/03/26, 14:37

  8. Simon Schaufelberger commented on patch set 6 02/03/26, 14:45

    I consider this a feature and would like to see a feature rst
  9. Oliver Hader voted on patch set 6 CR +2 V +2 02/03/26, 14:45

  10. Oliver Hader voted on patch set 6 CR +1 V +1 02/03/26, 14:45

  11. Oliver Hader commented on patch set 6 02/03/26, 14:47

    Reply

    `slideMode` was available already and is documented at https://docs.typo3.org/permalink/t3tsref:confval-mod-web-layout-backendlayouts-backendlayout-title-config-backend-layout-rows-row-columns-col-slidemode Personally I don't see a need, for making this a feature with corresponding RST file. What do you think?
  12. Matthias Vogel uploaded patch set 7 CR +1 V +1 02/03/26, 15:04

  13. Matthias Vogel commented on patch set 7 02/03/26, 15:04

    Reply

    Done
  14. core-ci voted on patch set 7 V +1 02/03/26, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94922

  15. Simon Praetorius voted on patch set 7 CR +1 V +1 02/03/26, 15:12

  16. Simon Schaufelberger voted on patch set 7 CR +1 V +1 02/03/26, 15:47

  17. Oliver Hader voted on patch set 7 CR +2 V +2 02/03/26, 15:55

  18. Oli Bartsch commented on patch set 7 02/03/26, 15:55

    ColumnHeader.fluid.html:21

    Could we do a `badge-info` here?
  19. Oliver Hader merged patch set 8 02/03/26, 15:56

  20. Oliver Hader commented on patch set 8 02/03/26, 15:56

    Unresolved

    Sorry, I obviously was too fast 😊
  21. Oli Bartsch commented on patch set 8 02/03/26, 16:32

    Post -1 We can not use the technical value here. No editor will understand why "collectReverse" is visible there. especially because he usually does not have any access on the backend layout configuration.
  22. Oliver Hader commented on patch set 8 02/03/26, 16:39

    Reply

    Okay. What would be your suggestion? - just show a dedicated icon there? - add more description (localizable) in a tool-tip? - completely revert this change?
  23. Matthias Vogel commented on patch set 8 02/03/26, 16:49

    Reply Unresolved

    I would suggest showing 3 dedicated icons. And I would suggest a followup patch.
  24. Benjamin Kott commented on patch set 8 02/03/26, 19:49

    ColumnHeader.fluid.html:21 Reply Unresolved

    nah keep the colors away if not really needed
  25. Oli Bartsch commented on patch set 8 02/04/26, 14:44

    locallang_layout.xlf:85 Unresolved

    It's the other way round