92643[FEATURE] Add Badge for Slide Mode in Layout Module
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Simon Praetorius +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oliver Hader +2
- Simon Praetorius +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumn.php+8 −0
- typo3/sysext/backend/Resources/Private/Language/locallang_layout.xlf1+9 −0
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid/ColumnHeader.fluid.html2+6 −1
- typo3/sysext/core/Classes/Page/ContentSlideMode.phprenamed+6 −1
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-108842-AddBadgeForSlideModeInLayoutModule.rstnew+26 −0
- typo3/sysext/frontend/Classes/Content/RecordCollector.php+1 −0
- typo3/sysext/frontend/Classes/DataProcessing/PageContentFetchingProcessor.php+1 −1
- typo3/sysext/frontend/Migrations/Code/ClassAliasMap.phpnew+20 −0
- typo3/sysext/frontend/composer.json+5 −0
- composer.json+1 −0
- composer.lock+1 −1
Review log 2532
Show 47 earlier messages
-
Matthias Vogel uploaded patch set 1 02/03/26, 11:47
-
core-ci voted on patch set 1 V -1 02/03/26, 11:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94897
-
Matthias Vogel uploaded patch set 2
V -102/03/26, 12:51 -
core-ci voted on patch set 2 V -1 02/03/26, 12:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94900
-
Matthias Vogel uploaded patch set 3
V -102/03/26, 13:07 -
core-ci voted on patch set 3 V -1 02/03/26, 13:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94902
-
Matthias Vogel uploaded patch set 4
V -102/03/26, 13:26
-
Matthias Vogel uploaded patch set 5 02/03/26, 13:29
-
Matthias Vogel uploaded patch set 6 02/03/26, 13:33
-
core-ci voted on patch set 4 V -1 02/03/26, 13:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94903
-
core-ci voted on patch set 5 V +1 02/03/26, 13:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94904
-
core-ci voted on patch set 6 V +1 02/03/26, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94907
-
Benni Mack voted on patch set 6 CR +1 V +1 02/03/26, 14:22
-
Oliver Hader voted on patch set 6 CR +1 02/03/26, 14:37
-
Simon Schaufelberger commented on patch set 6 02/03/26, 14:45
I consider this a feature and would like to see a feature rst -
Oliver Hader voted on patch set 6 CR +2 V +2 02/03/26, 14:45
-
Oliver Hader voted on patch set 6 CR +1 V +1 02/03/26, 14:45
-
Oliver Hader commented on patch set 6 02/03/26, 14:47
Reply
`slideMode` was available already and is documented at https://docs.typo3.org/permalink/t3tsref:confval-mod-web-layout-backendlayouts-backendlayout-title-config-backend-layout-rows-row-columns-col-slidemode Personally I don't see a need, for making this a feature with corresponding RST file. What do you think? -
Matthias Vogel uploaded patch set 7
CR +1V +102/03/26, 15:04 -
Matthias Vogel commented on patch set 7 02/03/26, 15:04
Reply
Done -
core-ci voted on patch set 7 V +1 02/03/26, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94922
-
Simon Praetorius voted on patch set 7 CR +1 V +1 02/03/26, 15:12
-
Simon Schaufelberger voted on patch set 7 CR +1 V +1 02/03/26, 15:47
-
Oliver Hader voted on patch set 7 CR +2 V +2 02/03/26, 15:55
-
Oli Bartsch commented on patch set 7 02/03/26, 15:55
ColumnHeader.fluid.html:21Could we do a `badge-info` here? -
Oliver Hader merged patch set 8 02/03/26, 15:56
-
Oliver Hader commented on patch set 8 02/03/26, 15:56
Unresolved
Sorry, I obviously was too fast 😊 -
Oli Bartsch commented on patch set 8 02/03/26, 16:32
Post -1 We can not use the technical value here. No editor will understand why "collectReverse" is visible there. especially because he usually does not have any access on the backend layout configuration. -
Oliver Hader commented on patch set 8 02/03/26, 16:39
Reply
Okay. What would be your suggestion? - just show a dedicated icon there? - add more description (localizable) in a tool-tip? - completely revert this change? -
Matthias Vogel commented on patch set 8 02/03/26, 16:49
Reply Unresolved
I would suggest showing 3 dedicated icons. And I would suggest a followup patch. -
Benjamin Kott commented on patch set 8 02/03/26, 19:49
ColumnHeader.fluid.html:21Reply Unresolvednah keep the colors away if not really needed -
Oli Bartsch commented on patch set 8 02/04/26, 14:44
locallang_layout.xlf:85UnresolvedIt's the other way round