92647[FEATURE] Add default password generator wizard for FE and BE users
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 22
- Build/Sources/TypeScript/backend/form-engine/field-control/password-generator.ts8+9 −3
- Build/Sources/TypeScript/backend/form-engine.ts3+1 −1
- typo3/sysext/backend/Classes/Form/FieldControl/PasswordGenerator.php+4 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/field-control/password-generator.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+1 −1
- typo3/sysext/core/Classes/Controller/PasswordGeneratorController.php8+45 −5
- typo3/sysext/core/Classes/PasswordPolicy/Generator/PasswordGenerator.phpnew+39 −0
- typo3/sysext/core/Classes/PasswordPolicy/Generator/PasswordGeneratorInterface.php4new+35 −0
- typo3/sysext/core/Configuration/TCA/be_users.php2+10 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php4+30 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Deprecation-69190-DeprecatePasswordRulesOptionInPasswordGeneratorFieldControl.rst2new+110 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-69190-AddPasswordGeneratorWizard.rst22new+116 −0
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf2+4 −1
- typo3/sysext/core/Tests/Functional/Controller/PasswordGeneratorControllerTest.phpnew+180 −0
- typo3/sysext/core/Tests/Unit/PasswordPolicy/Generator/PasswordGeneratorTest.php2new+142 −0
- typo3/sysext/frontend/Configuration/TCA/fe_users.php+10 −0
- typo3/sysext/install/Classes/Command/PasswordSetCommand.php9+25 −13
- typo3/sysext/install/Classes/ServiceProvider.php+7 −1
- typo3/sysext/install/Tests/Functional/Command/PasswordSetCommandTest.php+1 −2
- typo3/sysext/reactions/Configuration/TCA/sys_reaction.php+1 −4
Review log 86114
Show 6889 earlier messages
-
Simon Schaufelberger uploaded patch set 1 02/03/26, 17:25
-
core-ci voted on patch set 1 V -1 02/03/26, 17:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94932
-
Garvin Hicking commented on patch set 1 02/03/26, 18:13
PasswordSetCommand.php:104Please specify what would be broken exactly -
Simon Schaufelberger uploaded patch set 2
V -102/03/26, 18:23 -
Simon Schaufelberger commented on patch set 2 02/03/26, 18:29
Feature-69190-AddPasswordGeneratorWizard.rst:15Replywell, if you want to add the password generator wizard, you can attach it to basically every field (if you are dumb). How would you improve the text? I'm not so used to write doc 😄PasswordSetCommand.php:104ReplyI copied the message from PasswordHashFactory. Suggestions? -
core-ci voted on patch set 2 V -1 02/03/26, 18:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94935
-
Garvin Hicking commented on patch set 2 02/03/26, 21:59
Feature-69190-AddPasswordGeneratorWizard.rst:15Replysee suggestion, something like that?Feature-69190-AddPasswordGeneratorWizard.rst:15```suggestion frontend users. The necessary TCA configuration can also be applied to any other custom password field definition. These rules follow the the configuration that is defined in the ```PasswordSetCommand.php:104ReplySuggestion: The TYPO3_CONF_VARS.SYS.passwordPolicies.installTool.generator configuration is misconfigured. Please ensure that the subkey 'className' is set, and the subkey 'options' is an array of required option values. BTW: You'll also want to check for "className" is a string (empty could apply to an array), and maybe even do a class_exists() check on it? -
Simon Schaufelberger uploaded patch set 3
V -102/04/26, 10:22 -
Simon Schaufelberger commented on patch set 3 02/04/26, 10:23
Feature-69190-AddPasswordGeneratorWizard.rst:15ReplyDoneFeature-69190-AddPasswordGeneratorWizard.rst:15ReplyDonePasswordSetCommand.php:104ReplyDone -
core-ci voted on patch set 3 V -1 02/04/26, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94996
-
Simon Schaufelberger uploaded patch set 4
V -102/04/26, 10:44 -
Simon Schaufelberger uploaded patch set 5 02/04/26, 10:59
-
Simon Schaufelberger uploaded patch set 6 02/04/26, 11:08
-
Simon Schaufelberger uploaded patch set 7 02/04/26, 11:18
-
core-ci voted on patch set 7 V -1 02/04/26, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95012
-
Simon Schaufelberger uploaded patch set 8
V -102/04/26, 12:59 -
core-ci voted on patch set 8 V -1 02/04/26, 13:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95019
-
core-ci commented on patch set 8 02/04/26, 13:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95019
-
core-ci voted on patch set 8 V +1 02/04/26, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95019
-
Marno Schmigotzki commented on patch set 8 02/05/26, 15:13
I like that. Let's also add the password generator to the user module, where the user can set their own password. -
Marno Schmigotzki commented on patch set 8 02/05/26, 15:15
CorePasswordGenerator.php:35Perhaps we can use TYPO3\CMS\Core\Crypto\Random here. -
Marno Schmigotzki commented on patch set 8 02/05/26, 15:30
Reply
But we should wait for https://review.typo3.org/c/Packages/TYPO3.CMS/+/92653, so this is resolved for now. -
Simon Schaufelberger uploaded patch set 9
V +102/05/26, 15:57 -
Simon Schaufelberger commented on patch set 9 02/05/26, 16:00
CorePasswordGenerator.php:35ReplyDone -
Marno Schmigotzki voted on patch set 9 CR +1 V +1 02/05/26, 16:15
-
core-ci voted on patch set 9 V -1 02/05/26, 16:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95178
-
Simon Schaufelberger uploaded patch set 10
CR +1V +102/05/26, 18:51 -
core-ci voted on patch set 10 V +1 02/05/26, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95202
-
Marno Schmigotzki voted on patch set 10 CR +1 V +1 02/05/26, 20:14
-
Oli Bartsch commented on patch set 10 CR -1 02/06/26, 09:09
Please let me review this. -
Oliver Hader commented on patch set 10 02/06/26, 09:29
form-engine.ts:758At which point is this `undefined`?PasswordGeneratorController.php:51extract this to an own variableDefaultConfiguration.php:1458Let's use at least 12 chars hereDefaultConfiguration.php:1482Let's use at least 12 chars hereFeature-69190-AddPasswordGeneratorWizard.rst:31I think the example section can be simplified by showing how, the default generator is integrated with all options. -
Simon Schaufelberger commented on patch set 10 02/06/26, 10:22
form-engine.ts:758ReplyThis happened in user settings as there is no "real" formengine rendering used. It happens because t3js-formengine-palette-field and t3js-formengine-label don't exist and the return type is not null here but undefined.PasswordGeneratorController.php:51Replyhow? then i would need to do another check if the array exists with that value (which empty does already). I'm already extracting it in line 64.DefaultConfiguration.php:1458ReplyDoneDefaultConfiguration.php:1482ReplyDone -
Oliver Hader commented on patch set 10 02/06/26, 10:49
Update will follow...form-engine.ts:758ReplyDonePasswordGeneratorController.php:51ReplyDone -
Simon Schaufelberger uploaded patch set 11
CR +1V +102/06/26, 11:18 -
Oliver Hader commented on patch set 11 CR -1 02/06/26, 11:27
On it...PasswordSetCommand.php:71Still valid. -
core-ci voted on patch set 11 V -1 02/06/26, 11:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95268
-
Simon Schaufelberger commented on patch set 11 02/06/26, 11:37
Feature-69190-AddPasswordGeneratorWizard.rst:31ReplyDone -
core-ci commented on patch set 11 02/06/26, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95268
-
Simon Schaufelberger uploaded patch set 12
CR -1V -102/06/26, 11:39 -
core-ci voted on patch set 12 V +1 02/06/26, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95274
-
Oliver Hader uploaded patch set 13
V +102/06/26, 12:38 -
Oliver Hader commented on patch set 13 CR +1 V +1 02/06/26, 12:38
Reply
Done -
core-ci voted on patch set 13 V -1 02/06/26, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95283
-
core-ci voted on patch set 13 V +1 02/06/26, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95283
-
Marno Schmigotzki voted on patch set 13 CR +1 V +1 02/06/26, 13:10
-
Oli Bartsch commented on patch set 13 02/06/26, 13:20
SetupModuleController.php:694I don't get this comment. What should be checked?SetupModuleController.php:703Could this be a button please. -
Oli Bartsch commented on patch set 13 02/06/26, 13:22
Feature-69190-AddPasswordGeneratorWizard.rst:14This sentence sounds odd. -
Simon Schaufelberger commented on patch set 13 02/06/26, 13:47
Feature-69190-AddPasswordGeneratorWizard.rst:14ReplyMaybe Admin Backend users?SetupModuleController.php:694Replyhttps://review.typo3.org/c/Packages/TYPO3.CMS/+/92653 got merged but the TCA fieldConfig is not accessible yet. This needs to be fixed with another patch so that it can be read here and then the data attributes can be read directly from the TCA configuration.SetupModuleController.php:703ReplyIt's the same rendering as other wizards. Would you still do different rendering here? -
Oliver Hader uploaded patch set 14
CR +1V +102/06/26, 15:41 -
Oliver Hader commented on patch set 13 CR +1 V +1 02/06/26, 15:42
Feature-69190-AddPasswordGeneratorWizard.rst:14ReplyDoneSetupModuleController.php:703ReplySeems, like I missed to review the changes here. The form-engine pendant in `\TYPO3\CMS\Backend\Form\FieldControl\PasswordGenerator` is actually a field-control, not a wizard. -
core-ci voted on patch set 14 V +1 02/06/26, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95310
-
Torben Hansen commented on patch set 14 02/06/26, 16:57
CorePasswordGenerator.php:37The `generateRandomPassword` method has a hardcoded minimum length of 8 chars for a password. Our password policies do however not have any hardcoded limits and allow password length to be less than 8 chars. So either we remove the exception in `generateRandomPassword` when the password is less than 8 chars or we define a minimum length for passwords in `TYPO3\CMS\Core\PasswordPolicy\Validator`, which however is breaking. I therefore suggest to remove the exception in `generateRandomPassword` for the hardcoded length. -
Simon Schaufelberger commented on patch set 14 02/06/26, 17:20
CorePasswordGenerator.php:37ReplyWhy do you allow passwords shorter than 8 chars? -
Garvin Hicking commented on patch set 14 02/06/26, 17:24
CorePasswordGenerator.php:37ReplyDidnt check this in detail but could we not catch that exception for this specific case? -
Torben Hansen commented on patch set 14 02/06/26, 17:36
CorePasswordGenerator.php:37ReplyI did not write, that I allow passwords with less that 8 chars. My feedback just reflects the current technical state of the core implementation of the password policies, which I added in v12. The feature allows to configure the rules like the user/admin wants to - regardless of, if the configuration is good or bad. Having a hardcoded limit for the max. length here is therefore not good from a UX perspective (leading to an error message and no password generated), because it is not inline with a possible configured password policy with a minimum password length less than 8 chars. -
Simon Schaufelberger commented on patch set 14 02/06/26, 19:01
CorePasswordGenerator.php:37ReplyI would like to understand your usecase. > Our password policies do however not have any hardcoded limits and allow password length to be less than 8 chars. What exactly do you mean then with "our"? The core uses validators and the default is 8 characters. Yes you can define shorter lengths but then you are making TYPO3 a lot less secure. You can still manually set passwords shorter than 8 chars but the generator only allows generating passwords >= 8 chars. If you want, even with the password generator in place, you can still set a password 1234 if your validator length is 4. > Having a hardcoded limit for the max. length Where do you see a max length? -
Simon Schaufelberger commented on patch set 14 02/06/26, 19:05
SetupModuleController.php:703Replywhatever you name it, that "thing" renders an a tag and not a button. -
Torben Hansen commented on patch set 14 02/06/26, 19:18
CorePasswordGenerator.php:37ReplySorry for the confusion, I meant min. length instead of max. length. However, I think it is clear, that the generator and the configured min. password length should be inline and not lead to a message, which not fits to the configured password min length in the user configured password policy. -
Simon Schaufelberger commented on patch set 14 02/06/26, 19:19
Feature-69190-AddPasswordGeneratorWizard.rst:19> Generated passwords are validated against the policy's validators before being displayed That is NOT correct! The password is only validated when it is saved and not before. -
Simon Schaufelberger commented on patch set 14 02/06/26, 19:23
CorePasswordGenerator.php:37ReplyThe problem is that we already had validators and merging the configuration would mean a huge refactoring which is out of scope. Oli Hader and I were brainstorming a lot about this and decided that we do it this way for now that it is the responsibility of the developers to sync the settings. I bet the majority of users will never touch these settings anyway and simply use the defaults. -
Torben Hansen commented on patch set 14 02/07/26, 08:09
CorePasswordGenerator.php:37ReplyAgree, that the described mismatch would only affect users, where settings are not in sync. Just wanted to point out the hardcoded min. length in the generator, which could lead to an error message when password policy allows < 8 chars in password length. However, this is for sure an edge case and no blocker for the feature. -
Simon Schaufelberger commented on patch set 14 02/07/26, 10:22
CorePasswordGenerator.php:37ReplyI would say: let these people complain if they want but passwords shorter than 8 chars is nuts. -
Simon Schaufelberger commented on patch set 14 02/08/26, 20:26
Interesting fact: I just stumbled over this documentation and realized that we already have the possibility for a password generator: https://docs.typo3.org/permalink/t3tca:columns-password-example-generator What should we do with that? -
Simon Schaufelberger commented on patch set 14 02/08/26, 20:33
Reply
Sorry, ignore this comment. I'm too tired... -
Simon Schaufelberger uploaded patch set 15
V +102/09/26, 19:52 -
core-ci voted on patch set 15 V +1 02/09/26, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95487
-
Simon Schaufelberger commented on patch set 15 02/09/26, 20:15
Feature-69190-AddPasswordGeneratorWizard.rst:19ReplyDone -
Simon Schaufelberger uploaded patch set 16
V +102/09/26, 21:21 -
core-ci voted on patch set 16 V -1 02/09/26, 21:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95491
-
Simon Schaufelberger uploaded patch set 17
V -102/09/26, 21:57 -
core-ci voted on patch set 17 V -1 02/09/26, 22:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95492
-
Simon Schaufelberger uploaded patch set 18
V -102/09/26, 22:13 -
Simon Schaufelberger updated the commit message in patch set 19 02/09/26, 22:17
-
core-ci voted on patch set 19 V +1 02/09/26, 22:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95495
-
Oli Bartsch commented on patch set 19 V -1 02/10/26, 17:21
password-generator.ts:99Why is this an error now? The Generator is in my opinion a additional feature and does not prevent e.g. persisting the record. I would not use error here.PasswordGeneratorController.php:81So this triggers deprecation messages for webhooks and reactions now.CorePasswordGenerator.php:28Why do we need the `Core` prefix here? I think this is not common for core's own implementations.PasswordGeneratorInterface.php:22Let's describe this interface.PasswordSetCommand.php:99superfluous. just do `!class_exists($generator['className'] ?? '')`PasswordSetCommand.php:101superfluous. just do `!is_array($generator['options'] ?? null)`SetupModuleController.php:703ReplyAnd this is wrong. I has to be a `<button>`. -
Oli Bartsch commented on patch set 19 02/10/26, 17:23
Reply
DoneSetupModuleController.php:694ReplyDone -
Simon Schaufelberger commented on patch set 19 02/10/26, 17:31
password-generator.ts:99ReplyErrors will stay while notifications will disappear after a few sec. I will also show invalid configuration messages there and it is important you can read the whole message and yes, these are actually real errors!PasswordGeneratorController.php:81Replyhow do i reproduce this?CorePasswordGenerator.php:28ReplyI'm open for a better name!PasswordGeneratorInterface.php:22ReplyPlease make a suggestion -
Simon Schaufelberger commented on patch set 19 02/10/26, 17:32
SetupModuleController.php:703ReplyShould I then also fix this in the other wizard renderer in a separate patch? -
Oli Bartsch commented on patch set 19 02/10/26, 17:34
password-generator.ts:99ReplySo a message would be "Invalid password policies". What should a user now do with this other than contact his admin?PasswordGeneratorController.php:81ReplyCreate such record.CorePasswordGenerator.php:28Reply`PasswordGenerator`PasswordGeneratorInterface.php:22ReplyI'm not the one introducing the interface. I have no idea what it is for. -
Simon Schaufelberger commented on patch set 19 02/10/26, 20:19
password-generator.ts:99ReplyNo, the error message will be the exception message because the exceptions are caught and then the message is returned in the response. A user can at least tell the admin what is wrong with a precise error message instead of "an unknown error occured" 😄 If any error occurs that means that the whole system is totally broken. That means that the password generator doesn't work at all which the developer should test of course so he would be the one that would see the message and since there is no error page, showing a notification with the error message would be the most helpful.PasswordGeneratorController.php:81ReplyI completely forgot about that the PW generator is also used there. @oliver.hader@typo3.org As we talked about the new way of using policies, what would be your idea about generating webhook/reaction secrets with a random hash? @garvin@hick.ing and I had a personal chat and he suggested to deprecate the direct usage of the Random password generator meaning this section here and use the upper section always but that would mean to add another policy for that use case. What do you think about that? The longer this patch lies around, the more questions come up... I have the feeling this patch will end up in a never ending story and all the work that I put into it will be wasted in the end which would be very sad.CorePasswordGenerator.php:28ReplyDonePasswordGeneratorInterface.php:22ReplyDonePasswordSetCommand.php:99ReplyDonePasswordSetCommand.php:101ReplyDone -
Simon Schaufelberger uploaded patch set 20
V +102/10/26, 20:20 -
core-ci voted on patch set 20 V +1 02/10/26, 20:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95575
-
Simon Schaufelberger commented on patch set 20 02/11/26, 09:09
SetupModuleController.php:703ReplyDone -
Georg Ringer commented on patch set 20 CR -1 02/11/26, 10:07
can't we just skip the "default"?be_users.php:56use new syntax for new codeFeature-69190-AddPasswordGeneratorWizard.rst:28I miss a hint that the password generator wizard is not related to the policies, so it is totally possible that the generated password might still fail if requirements are not met, like using haveibeenpwned. Personally this feels very wrong, generating passwords which will fail in the next stepFeature-69190-AddPasswordGeneratorWizard.rst:71upper case -
Simon Schaufelberger uploaded patch set 21
CR -1V +102/16/26, 21:09 -
Simon Schaufelberger commented on patch set 20 02/16/26, 21:09
Reply
not really. before it was optional to have a password generator, now it is activated by default.be_users.php:56ReplyDoneFeature-69190-AddPasswordGeneratorWizard.rst:28ReplyTo be honest, the whole concept was not well thought through right from the beginning. On the other hand, the setup allows flexible configurations for example generate a password with 20 chars but since you don't necessarily need to use the generator, you can also set a minimum length of 12 chars in the validators. Of course if the generator generates a weak password and your rules are stricter, then you are just dumb. I guess we can require the people adjusting this configuration to be smart enough to not do stupid things and release broken generators.Feature-69190-AddPasswordGeneratorWizard.rst:71ReplyDone -
Simon Schaufelberger commented on patch set 21 02/16/26, 21:10
Reply
Done -
Simon Schaufelberger commented on patch set 21 02/16/26, 21:10
Feature-69190-AddPasswordGeneratorWizard.rst:28ReplyDone -
core-ci voted on patch set 21 V +1 02/16/26, 21:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95998
-
Simon Schaufelberger uploaded patch set 22
V +102/23/26, 12:06 -
core-ci voted on patch set 22 V -1 02/23/26, 12:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96566
-
core-ci voted on patch set 22 V +1 02/23/26, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96566
-
Oli Bartsch uploaded patch set 23
V +103/04/26, 11:25 -
core-ci voted on patch set 23 V +1 03/04/26, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97302
-
Oli Bartsch uploaded patch set 24
V +103/04/26, 11:36 -
Oli Bartsch commented on patch set 24 CR +1 V +1 03/04/26, 11:36
password-generator.ts:99ReplyI think this was a misunderstanding of my initial point. We should inform the user but with a warning, not an error. I have updated this accordingly.PasswordGeneratorController.php:81ReplyI've added a specific policy for this now. -
core-ci voted on patch set 24 V +1 03/04/26, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97309
-
Simon Schaufelberger commented on patch set 24 03/04/26, 14:29
password-generator.ts:99ReplyPlease leave it as an error because warnings disappear quickly again and you have no time to read the actual error message when you have an exception. Otherwise implement a way to make the warnings stay until closed manually. -
Oli Bartsch uploaded patch set 25
CR +1V +103/04/26, 18:24 -
Oli Bartsch commented on patch set 25 CR +1 V +1 03/04/26, 18:26
password-generator.ts:99ReplyAs discussed in slack, instead of showing editors messages like `Password generation failed- LogicException: Class TYPO3\CMS\Core\PasswordPolicy\Generator\PasswordGenerator does not implement PasswordGeneratorInterface,` we now just log the message and inform the user that the generation did not work. An Admin can look up what caused this. -
Simon Schaufelberger commented on patch set 25 CR +1 V +1 03/04/26, 18:33
password-generator.ts:99ReplyDone -
core-ci voted on patch set 25 V -1 03/04/26, 18:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97353
-
Simon Schaufelberger uploaded patch set 26
CR +1V +103/04/26, 18:53 -
Simon Schaufelberger uploaded patch set 27 03/04/26, 18:58
-
core-ci voted on patch set 27 V +1 03/04/26, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97357
-
Oli Bartsch voted on patch set 27 CR +1 V +1 03/04/26, 19:11
-
Georg Ringer commented on patch set 27 03/04/26, 20:18
Deprecation-69190-DeprecatePasswordRulesOptionInPasswordGeneratorFieldControl.rst:14IMO we go with single quotesFeature-69190-AddPasswordGeneratorWizard.rst:15single quotesFeature-69190-AddPasswordGeneratorWizard.rst:112Install Toollocallang_core.xlf:538can we give the user a hint how to solve? reloading or does it need a new different configuration? without checking: is the error logged?PasswordGeneratorTest.php:44should we use mb_strlen? -
Simon Schaufelberger commented on patch set 27 03/04/26, 20:51
Deprecation-69190-DeprecatePasswordRulesOptionInPasswordGeneratorFieldControl.rst:14ReplyDoneFeature-69190-AddPasswordGeneratorWizard.rst:15ReplyDoneFeature-69190-AddPasswordGeneratorWizard.rst:112ReplyDonelocallang_core.xlf:538Reply UnresolvedA user cannot solve this issue. It means a technical error like misconfiguration. What would you suggest? Yes, the error will be logged.PasswordGeneratorTest.php:44ReplyDone -
Simon Schaufelberger uploaded patch set 28
CR +1V +103/04/26, 20:51 -
Georg Ringer voted on patch set 28 CR +1 V +1 03/04/26, 20:53
-
Oli Bartsch voted on patch set 28 CR +1 V +1 03/04/26, 20:55
-
core-ci voted on patch set 28 V +1 03/04/26, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97361
-
Oli Bartsch voted on patch set 28 CR +2 V +2 03/04/26, 22:03
-
Oli Bartsch merged patch set 29 03/04/26, 22:03
Feature-69190-AddPasswordGeneratorWizard.rst:15