92650[FEATURE] Introduce Fluid `render.text/richtText` ViewHelpers
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Oli Bartsch +1
-
Verified V +2 Done
- Oliver Hader +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 16
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-108868-IntroduceFluidRenderRichTextViewHelper.rst9new+95 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-108868-IntroduceFluidRenderTextViewHelper.rst8new+101 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Render/RichTextViewHelper.php6new+79 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Render/TextViewHelper.php21new+81 −0
- typo3/sysext/theme_camino/Resources/Private/Templates/Content/CaminoAuthor.fluid.html6+9 −9
- typo3/sysext/theme_camino/Resources/Private/Templates/Content/CaminoLinklist.fluid.html+1 −1
- typo3/sysext/theme_camino/Resources/Private/Templates/Content/CaminoTestimonial.fluid.html+5 −4
- typo3/sysext/theme_camino/Resources/Private/Templates/Content/CaminoTextmediaTeaser.fluid.html2+4 −5
- typo3/sysext/theme_camino/Resources/Private/Templates/Content/CaminoTextmediaTeaserGrid.fluid.html+12 −10
- typo3/sysext/theme_camino/Resources/Private/Templates/Content/CaminoTextteaser.fluid.html+4 −5
- typo3/sysext/theme_camino/Resources/Private/Templates/Layouts/Content/Default.fluid.html+1 −1
- typo3/sysext/theme_camino/Resources/Private/Templates/Partials/Components/Intro.fluid.html2+1 −10
- typo3/sysext/theme_camino/Resources/Private/Templates/Partials/Components/Textmediateaser.fluid.html+4 −10
- typo3/sysext/theme_camino/Resources/Private/Templates/Partials/Content/Hero.fluid.html+3 −3
- typo3/sysext/theme_camino/Resources/Private/Templates/Partials/Content/Textpic.fluid.html+7 −6
- typo3/sysext/theme_camino/Resources/Public/Css/_hero.css2+0 −1
Review log 4466
Show 2441 earlier messages
-
Matthias Vogel uploaded patch set 1 02/03/26, 19:50
-
Matthias Vogel marked it work in progress 02/03/26, 19:50
-
core-ci voted on patch set 1 V +1 02/03/26, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94938
-
Matthias Vogel uploaded patch set 2
V +102/03/26, 20:07 -
core-ci voted on patch set 2 V -1 02/03/26, 20:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94941
-
Matthias Vogel rebased onto patch set 3
V -102/04/26, 06:39 -
core-ci voted on patch set 3 V +1 02/04/26, 06:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94970
-
Matthias Vogel rebased onto patch set 4
V +102/04/26, 08:15 -
core-ci voted on patch set 4 V +1 02/04/26, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94975
-
Matthias Vogel rebased onto patch set 5
V +102/04/26, 09:28 -
Matthias Vogel uploaded patch set 6 02/04/26, 09:39
-
core-ci voted on patch set 6 V -1 02/04/26, 09:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94987
-
core-ci voted on patch set 5 V +1 02/04/26, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94983
-
Matthias Vogel rebased onto patch set 7
V -102/04/26, 13:21 -
core-ci voted on patch set 7 V -1 02/04/26, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95025
-
Matthias Vogel rebased onto patch set 8
V -102/04/26, 13:52 -
Matthias Vogel rebased onto patch set 9 02/04/26, 13:56
-
Matthias Vogel rebased onto patch set 10 02/04/26, 14:15
-
core-ci voted on patch set 8 V -1 02/04/26, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95030
-
core-ci voted on patch set 9 V -1 02/04/26, 14:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95034
-
core-ci voted on patch set 10 V -1 02/04/26, 14:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95039
-
Matthias Vogel rebased onto patch set 11
V -102/04/26, 14:37 -
core-ci voted on patch set 11 V -1 02/04/26, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95043
-
Matthias Vogel rebased onto patch set 12
V -102/04/26, 15:30 -
core-ci voted on patch set 12 V -1 02/04/26, 16:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95062
-
Matthias Vogel rebased onto patch set 13
V -102/04/26, 16:24 -
core-ci voted on patch set 13 V -1 02/04/26, 16:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95070
-
Matthias Vogel uploaded patch set 14
V -102/05/26, 08:20 -
core-ci voted on patch set 14 V +1 02/05/26, 08:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95110
-
Matthias Vogel uploaded patch set 15
V +102/05/26, 09:34 -
core-ci voted on patch set 15 V -1 02/05/26, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95116
-
Simon Praetorius commented on patch set 15 02/05/26, 11:25
Feature-108868-IntroduceFluidRenderTextViewHelper.rst:15```suggestion to render record fields containing plain text content. ```RichTextViewHelper.php:43Let's leave this out in the first iteration. Then we still have the possibility to establish a better, more generic API once it becomes necessary.TextViewHelper.php:28Should already be done based on `ViewHelperInterface`TextViewHelper.php:29Let's make both VH finalTextViewHelper.php:31We should consider setting `$escapeOutput = false`, even though it's functionally not necessary because of `UnsafeHTML`. This will avoid an unnecessary `EscapingNode` and thus reduces code to be executed (both uncached and cached).TextViewHelper.php:42maybe `convertNewlines`?TextViewHelper.php:52Can we clarify the use case here? I think it's ok to give extensions a little wiggle-room here, we just should explain why we need this.TextViewHelper.php:58With recent Fluid changes, this should always be a string.TextViewHelper.php:66What should `??` cover here? Undefined fields will still lead to an exception.CaminoTextmediaTeaser.fluid.html:15There is still a check for `textHtml` in `Textmediateaser.fluid.html`.Intro.fluid.html:29`<p>` is missing now. Is that a problem? -
Matthias Vogel uploaded patch set 16
V -102/05/26, 13:25 -
Matthias Vogel commented on patch set 16 02/05/26, 13:25
This change is ready for review.Feature-108868-IntroduceFluidRenderRichTextViewHelper.rst:60ReplyDoneFeature-108868-IntroduceFluidRenderTextViewHelper.rst:15ReplyDoneRichTextViewHelper.php:43ReplyDoneTextViewHelper.php:28ReplyDoneTextViewHelper.php:29ReplyDoneTextViewHelper.php:31ReplyDoneTextViewHelper.php:42ReplyDoneTextViewHelper.php:52ReplyDoneTextViewHelper.php:58ReplyDoneTextViewHelper.php:66Replysome times we get null instead of empty string. If the database is Nullable.CaminoTextmediaTeaser.fluid.html:15ReplyDoneIntro.fluid.html:29ReplyThe text is only richText, it was never `textHTML: 0`. -
core-ci voted on patch set 16 V +1 02/05/26, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95148
-
Simon Praetorius uploaded patch set 17
V +102/05/26, 14:36 -
Matthias Vogel uploaded patch set 18 02/05/26, 14:51
-
Simon Praetorius voted on patch set 18 CR +1 V +1 02/05/26, 14:55
-
core-ci voted on patch set 18 V +1 02/05/26, 15:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95166
-
Georg Ringer commented on patch set 18 V -1 02/05/26, 15:42
TextViewHelper.php:66should we also du a trim to avoid false line breaks?TextViewHelper.php:72we don't use the global namespacepage.tsconfig:145skip this change -
Georg Ringer commented on patch set 18 02/05/26, 15:46
CaminoAuthor.fluid.html:26is is not needed to render it with the new viewhelpers?_hero.css:41unrelated change
-
Matthias Vogel commented on patch set 18 02/05/26, 16:02
TextViewHelper.php:66Replyif you want a newline at the beginning you should get one. the f:format.nl2br is also without trim. And I want to be comaptible with it.TextViewHelper.php:72ReplyI did not find it in the documentation. https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/CodingGuidelines/CglPhp/GeneralRequirementsForPhpFiles.html It is slitly more performant if prefixed with \ https://tideways.com/profiler/blog/compiler-optimized-php-functionspage.tsconfig:145ReplyDonepage.tsconfig:145ReplyDonepage.tsconfig:145ReplyDoneCaminoAuthor.fluid.html:24```suggestion <f:if condition="{bodytext}"> ```CaminoAuthor.fluid.html:26Replygood catch 👍CaminoAuthor.fluid.html:26Replygood catch 👍 -
Matthias Vogel uploaded patch set 19
CR +1V +102/05/26, 16:03 -
Matthias Vogel commented on patch set 18 02/05/26, 16:04
CaminoAuthor.fluid.html:24ReplyDoneCaminoAuthor.fluid.html:26ReplyDone -
core-ci voted on patch set 19 V +1 02/05/26, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95179
-
Oli Bartsch commented on patch set 19 02/05/26, 17:45
RichTextViewHelper.php:66I think we don't need the factory here since text has usually no "special" resolvingRichTextViewHelper.php:69Let's check for string here to: 1. Do not run the below code 2. Prevent TypeError'sTextViewHelper.php:72comment: We need to manually escape the output here to pass it to UnsafeHTMLString. -
Oli Bartsch commented on patch set 19 02/05/26, 17:45
_hero.css:41ReplyThis is an unnecessary property which leads to unintended side effects in preview like modules. -
Benni Mack commented on patch set 19 02/05/26, 18:02
tbh, I don't understand as a regular / outsider when to use this VH and when to use <f:format.html>... -
Matthias Vogel uploaded patch set 20
V +102/05/26, 20:06 -
core-ci voted on patch set 20 V -1 02/05/26, 20:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95207
-
Matthias Vogel uploaded patch set 21
V -102/05/26, 20:25 -
Matthias Vogel commented on patch set 21 02/05/26, 20:26
RichTextViewHelper.php:66ReplyDoneRichTextViewHelper.php:69ReplyDoneTextViewHelper.php:72ReplyDoneTextViewHelper.php:72ReplyDone -
core-ci voted on patch set 21 V +1 02/05/26, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95209
-
Oli Bartsch uploaded patch set 22
V +102/05/26, 21:20 -
Oli Bartsch voted on patch set 22 CR +1 V +1 02/05/26, 21:21
-
core-ci voted on patch set 22 V -1 02/05/26, 21:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95215
-
Oliver Hader voted on patch set 22 CR +2 V +2 02/05/26, 21:45
-
Simon Praetorius commented on patch set 22 02/05/26, 21:46
Feature-108868-IntroduceFluidRenderRichTextViewHelper.rst:22This one needs to be clarified. I'm confused. Also, from my understanding, the ViewHelper does not decouple it, rather the opposite. But maybe I'm thinking of another coupling here. :-/Feature-108868-IntroduceFluidRenderRichTextViewHelper.rst:69Here as well, I don't get this coupling. -
core-ci voted on patch set 22 V +1 02/05/26, 21:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95215
-
Oliver Hader commented on patch set 22 02/05/26, 21:51
Feature-108868-IntroduceFluidRenderRichTextViewHelper.rst:22ReplyAcknowledgedFeature-108868-IntroduceFluidRenderRichTextViewHelper.rst:69ReplyAcknowledged -
Oliver Hader merged patch set 23 02/05/26, 21:52
-
Garvin Hicking commented on patch set 23 02/05/26, 22:05
Feature-108868-IntroduceFluidRenderRichTextViewHelper.rst:41I think this is wrong markup -
Simon Schaufelberger commented on patch set 23 02/05/26, 22:25
Feature-108868-IntroduceFluidRenderRichTextViewHelper.rst:41ReplyYes, this must be a stringFeature-108868-IntroduceFluidRenderTextViewHelper.rst:39Field must be a string -
Markus Klein commented on patch set 23 02/06/26, 07:00
Feature-108868-IntroduceFluidRenderTextViewHelper.rst:73I do not get, what this sentence wants to tell me. "needs to be displayed as intended"? I hope things are displayed as intended. "output is processed in the same order as it is rendered"? I'm not sure what this is referring to. How can this be not the case, currently? Maybe an example helps?Feature-108868-IntroduceFluidRenderTextViewHelper.rst:94Why does it make things more flexible? I can't deduce this from this rst, sorry. -
Matthias Vogel commented on patch set 23 02/10/26, 21:17
Feature-108868-IntroduceFluidRenderRichTextViewHelper.rst:41ReplyDoneFeature-108868-IntroduceFluidRenderTextViewHelper.rst:39ReplyDoneFeature-108868-IntroduceFluidRenderTextViewHelper.rst:73ReplyDoneFeature-108868-IntroduceFluidRenderTextViewHelper.rst:94ReplyDone -
Markus Klein commented on patch set 23 08/11/26, 14:16
regression with https://forge.typo3.org/issues/110439
Feature-108868-IntroduceFluidRenderRichTextViewHelper.rst:60