Review main Merged

92654[TASK] Skip system extensions in fluid:analyse CLI

Simon Praetorius CR +2 V +2 Easy +36 −6 updated 02/04/26, 16:21

Commit message

With this patch, the recently introduced `fluid:analyse` CLI command
only scans non-system extensions by default. System extensions can
be included again by specifying the `--include-system-extensions` CLI
option.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Matthias Vogel +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Matthias Vogel +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1215

  1. Simon Praetorius uploaded patch set 1 02/04/26, 07:17

  2. core-ci voted on patch set 1 V +1 02/04/26, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94971

  3. Simon Praetorius updated the commit message in patch set 2 V +1 02/04/26, 08:28

  4. core-ci voted on patch set 2 V +1 02/04/26, 08:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94976

  5. Oliver Klee commented on patch set 2 02/04/26, 08:51

    TemplateFinder.php:38

    In general, negated boolean parameters/options tend to confuse people and hence to decrease DX. Maybe switch that to `$includeFrameworkPackages`?
  6. Simon Praetorius uploaded patch set 3 V +1 02/04/26, 09:37

  7. Simon Praetorius commented on patch set 3 02/04/26, 09:37

    TemplateFinder.php:38 Reply

    Done
  8. Matthias Vogel voted on patch set 3 CR +1 V +1 02/04/26, 10:01

  9. core-ci voted on patch set 3 V +1 02/04/26, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94985

  10. Oliver Klee voted on patch set 3 CR +1 V +1 02/04/26, 12:42

  11. Simon Praetorius voted on patch set 3 CR +2 V +2 02/04/26, 12:51

  12. Simon Praetorius voted on patch set 3 CR 0 V 0 02/04/26, 12:51

  13. Garvin Hicking voted on patch set 3 CR +1 V +1 02/04/26, 16:17

  14. Simon Praetorius voted on patch set 3 CR +2 V +2 02/04/26, 16:21

  15. Simon Praetorius merged patch set 4 02/04/26, 16:21