92662[FEATURE] Add PSR-14 event to adjust QR code rendering
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 6
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/62/92662/6 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/62/92662/6 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -2 Blocked
- Benni Mack -2
- Markus Klein +1
- Josua Vogel +1
- Simon Schaufelberger +1
-
Verified V +1 Needs a vote
- Markus Klein +1
- Josua Vogel +1
- Simon Schaufelberger +1
- core-ci +1 CI
Merge conflicts 1
Issues 1
Files 5
- typo3/sysext/backend/Classes/Backend/QrCodeSize.php+1 −1
- typo3/sysext/backend/Classes/Controller/Event/BeforeQrCodeRenderedEvent.phpnew+94 −0
- typo3/sysext/backend/Classes/Controller/QrCodeController.php6+16 −5
- typo3/sysext/backend/Tests/Functional/Controller/QrCodeControllerTest.php+112 −1
- typo3/sysext/core/Documentation/Changelog/15.0/Feature-108854-PSR-14EventToAdjustQrCodeRendering.rstnew+139 −0
Review log 2229
Show 4 earlier messages
-
Markus Klein commented on patch set 2 02/04/26, 13:18
QrCodeController.php:115Optional idea: Introduce QR-renderer-Registry so we don't render stuff twice? -
Simon Schaufelberger commented on patch set 2 02/04/26, 13:22
Feature-108854-PSR-14EventToModifyQrCodeSvg.rst:57Since this is an event listener, the class name should also have the suffix EventListener -
core-ci voted on patch set 1 V -1 02/04/26, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95020
-
Oli Bartsch commented on patch set 2 02/04/26, 13:49
QrCodeController.php:115ReplyYes, that came to mind when I saw the event is dispatched after the SVG has already been rendered. However, maybe we can skip a full registry and just register a default event listener in EXT:backend. Due to loading order, extension listeners could intercept it — or alternatively, if we don't want to rely on loading order, the listener service can just be disabled via container config.Feature-108854-PSR-14EventToModifyQrCodeSvg.rst:25What's the point of providing rendered SVG markup here?Feature-108854-PSR-14EventToModifyQrCodeSvg.rst:57ReplyI would like to stick to our latetst changelogs and use the PHP Attribute on method level. -
core-ci voted on patch set 2 V -1 02/04/26, 13:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95021
-
Garvin Hicking commented on patch set 2 02/04/26, 14:52
QrCodeController.php:115ReplyI'm also in favor of having an authoritative render listener which can be replaced. I'd like to keep the possibility to getSvg() though, so custom listeners could just enrich the created SVG in postprocessing. -
Markus Klein commented on patch set 2 02/04/26, 14:57
QrCodeController.php:115ReplyThinking even further: QR codes might be specific per site -
Simon Schaufelberger uploaded patch set 3
CR +1V -103/27/26, 08:55 -
Simon Schaufelberger commented on patch set 2 03/27/26, 08:56
QrCodeController.php:115ReplyI added the Site. Anybody wants to suggest the proposed event listener? I'm not sure about the implementation -
core-ci voted on patch set 3 V -1 03/27/26, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98843
-
Simon Schaufelberger rebased onto patch set 4
V -103/30/26, 23:37 -
core-ci voted on patch set 4 V -1 03/30/26, 23:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99156
-
core-ci commented on patch set 4 03/31/26, 00:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99191
-
Georg Ringer uploaded patch set 5
V -109/09/26, 21:39 -
core-ci voted on patch set 5 V +1 09/09/26, 21:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108218
-
Markus Klein voted on patch set 5 CR +1 09/10/26, 09:40
-
Wouter Wolters voted on patch set 5 CR +1 V +1 09/16/26, 19:15
-
Georg Ringer uploaded patch set 6
CR +1V +111/03/26, 21:02 -
Georg Ringer commented on patch set 6 11/03/26, 21:04
QrCodeController.php:115ReplyThe event is dispatched before rendering, so the QR code is rendered only once. Listeners that need per-site output can match the encoded content against the site base URLs, as the request carries no resolved site. Post-processing of the SVG is covered by rendering it in the listener and assigning the result with setSvg().Feature-108854-PSR-14EventToModifyQrCodeSvg.rst:25ReplyDoneFeature-108854-PSR-14EventToModifyQrCodeSvg.rst:57ReplyDone -
core-ci voted on patch set 6 V +1 11/03/26, 21:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113230
-
Markus Klein voted on patch set 6 CR +1 V +1 11/04/26, 11:44
-
Simon Schaufelberger voted on patch set 6 CR +1 V +1 11/06/26, 09:26
-
Josua Vogel voted on patch set 6 CR +1 11/06/26, 09:31
-
Josua Vogel voted on patch set 6 V +1 11/16/26, 11:41
-
Benni Mack commented on patch set 6 CR -2 11/16/26, 11:49
let me check sth before we get this in.