Review main Merged

92666[TASK] Introduce decorative state color tokens adding lime and indigo

Benjamin Kott CR +2 V +2 Hard +287 −59 updated 02/05/26, 15:25

Commit message

Adds a complete set of decorative color state tokens for non-semantic
color usage such as workspace indicators, category tags, or user-assigned
labels. The palette includes: red, orange, yellow, lime, green, teal,
blue, indigo, purple, and magenta - sorted by hue.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1014

  1. Benjamin Kott uploaded patch set 1 02/04/26, 16:02

  2. core-ci voted on patch set 1 V +1 02/04/26, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95063

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 02/05/26, 07:18

  4. Benjamin Franzke commented on patch set 1 02/05/26, 07:53

    _root.scss:258

    This results in ~5.5 contrast ratio in light mode, which is good, but we should `-1` instead, which improves the contrast alot (we do the same with `-danger`)
  5. Benjamin Franzke commented on patch set 1 02/05/26, 11:53

    _root.scss:258 Reply

    > contrast alot note: I didn't actually measure the difference, this was a subjective observation, comparing danger and state-red.
  6. Benjamin Kott uploaded patch set 2 CR +1 V +1 02/05/26, 14:49

  7. Benjamin Kott commented on patch set 2 02/05/26, 14:50

    _root.scss:258 Reply

    everything remeasured and aligned
  8. Benjamin Franzke voted on patch set 2 CR +1 V +1 02/05/26, 14:57

  9. core-ci voted on patch set 2 V -1 02/05/26, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95164

  10. core-ci commented on patch set 2 02/05/26, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95164

  11. core-ci voted on patch set 2 V +1 02/05/26, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95164

  12. Andreas Kienast voted on patch set 2 CR +1 V +1 02/05/26, 15:24

  13. Benjamin Kott voted on patch set 2 CR +2 V +2 02/05/26, 15:25

  14. Benjamin Kott merged patch set 3 02/05/26, 15:25