92668[TASK] Add visual feedback if CType is not allowed in column
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php6+18 −1
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php2+21 −3
- typo3/sysext/backend/Classes/View/BackendLayoutView.php+4 −0
- typo3/sysext/core/Classes/Localization/LanguageService.php1+3 −3
- typo3/sysext/core/Resources/Private/Language/locallang_core.xlf2+3 −0
Review log 2434
Show 79 earlier messages
-
Bastien Lutz uploaded patch set 1 02/04/26, 17:01
-
core-ci voted on patch set 1 V -1 02/04/26, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95073
-
Bastien Lutz uploaded patch set 2
V -102/04/26, 17:16 -
core-ci voted on patch set 2 V +1 02/04/26, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95075
-
Garvin Hicking commented on patch set 2 02/04/26, 17:47
GridColumnItem.php:184Also herelocallang_core.xlf:445```suggestion <source>Invalid value ("%s"). This element is not allowed in this column.</source> ``` -
Georg Ringer commented on patch set 2 02/04/26, 19:31
StandardContentPreviewRenderer.php:120should we add that check to a dedicated method? I am pretty sure we and others need that more than once and will get it wrong as well -
Benjamin Kott commented on patch set 2 02/05/26, 06:22
StandardContentPreviewRenderer.php:120Replyi want to second that, it feels wrong to ask an item after creation if it´s allowed or disallowed here. also the check reads strange itself. with negating allowed and disallowed if something is allowed, it cannot be disallowed. we should simplify this. but also the check needs to be moved somewhere, else to be of general use and not be hidden in the grid column item -
Bastien Lutz commented on patch set 2 02/05/26, 13:05
StandardContentPreviewRenderer.php:120Replya dedicated method will be introduced with the patch 92679. This patch is meanwhile on hold. -
Bastien Lutz uploaded patch set 3
V +102/05/26, 17:33
-
Bastien Lutz commented on patch set 3 02/05/26, 17:34
StandardContentPreviewRenderer.php:120ReplyDoneStandardContentPreviewRenderer.php:122ReplyDoneGridColumnItem.php:184ReplyDonelocallang_core.xlf:445ReplyDone -
core-ci voted on patch set 3 V +1 02/05/26, 17:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95194
-
Bastien Lutz uploaded patch set 4
V +102/05/26, 18:33 -
core-ci voted on patch set 4 V -1 02/05/26, 18:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95201
-
Bastien Lutz uploaded patch set 5
V -102/05/26, 20:03 -
Marno Schmigotzki voted on patch set 5 CR +1 V +1 02/05/26, 20:13
-
Garvin Hicking commented on patch set 5 02/05/26, 20:38
LanguageService.php:116oh nice driveby!!! -
core-ci voted on patch set 5 V +1 02/05/26, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95206
-
Bastien Lutz rebased onto patch set 6
CR +1V +102/10/26, 07:14The following files contain Git conflicts: * typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php -
Bastien Lutz uploaded patch set 7 02/10/26, 07:19
-
core-ci voted on patch set 6 V -1 02/10/26, 07:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95524
-
core-ci voted on patch set 7 V +1 02/10/26, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95525
-
Bastien Lutz marked it ready for review 02/10/26, 07:33
-
Oli Bartsch commented on patch set 7 V -1 02/10/26, 12:40
Using the same labeling "Invalid Value" confuses a lot. Will update -
Oli Bartsch uploaded patch set 8
V +102/10/26, 13:45 -
core-ci voted on patch set 8 V -1 02/10/26, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95548
-
Bastien Lutz voted on patch set 8 CR +1 V +1 02/10/26, 14:27
-
Oli Bartsch uploaded patch set 9
CR +1V +102/10/26, 15:54 -
core-ci voted on patch set 9 V -1 02/10/26, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95559
-
Oli Bartsch uploaded patch set 10
V -102/10/26, 16:09 -
core-ci voted on patch set 10 V +1 02/10/26, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95560
-
Georg Ringer voted on patch set 10 CR +1 V +1 02/10/26, 16:35
-
Anja Leichsenring voted on patch set 10 CR +1 V +1 02/10/26, 19:08
-
Oli Bartsch commented on patch set 10 CR +2 V +2 02/10/26, 22:07
Reply
Done -
Oli Bartsch merged patch set 11 02/10/26, 22:07
StandardContentPreviewRenderer.php:122