Review main Merged

92668[TASK] Add visual feedback if CType is not allowed in column

Bastien Lutz CR +2 V +2 Normal +49 −7 updated 02/10/26, 22:07

Commit message

When a backend layout limits columns to specific CTypes, any
existing content elements that no longer comply with these
restrictions should be visually marked to make them easy
for editors to identify.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Georg Ringer +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 2434

Show 79 earlier messages
  1. Bastien Lutz uploaded patch set 1 02/04/26, 17:01

  2. core-ci voted on patch set 1 V -1 02/04/26, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95073

  3. Bastien Lutz uploaded patch set 2 V -1 02/04/26, 17:16

  4. core-ci voted on patch set 2 V +1 02/04/26, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95075

  5. Garvin Hicking commented on patch set 2 02/04/26, 17:47

    StandardContentPreviewRenderer.php:122

    Please use the new core.messages:labels... translation domain syntax here

    GridColumnItem.php:184

    Also here

    locallang_core.xlf:445

    ```suggestion <source>Invalid value ("%s"). This element is not allowed in this column.</source> ```
  6. Georg Ringer commented on patch set 2 02/04/26, 19:31

    StandardContentPreviewRenderer.php:120

    should we add that check to a dedicated method? I am pretty sure we and others need that more than once and will get it wrong as well
  7. Benjamin Kott commented on patch set 2 02/05/26, 06:22

    StandardContentPreviewRenderer.php:120 Reply

    i want to second that, it feels wrong to ask an item after creation if it´s allowed or disallowed here. also the check reads strange itself. with negating allowed and disallowed if something is allowed, it cannot be disallowed. we should simplify this. but also the check needs to be moved somewhere, else to be of general use and not be hidden in the grid column item
  8. Bastien Lutz commented on patch set 2 02/05/26, 13:05

    StandardContentPreviewRenderer.php:120 Reply

    a dedicated method will be introduced with the patch 92679. This patch is meanwhile on hold.
  9. Bastien Lutz uploaded patch set 3 V +1 02/05/26, 17:33

  1. Bastien Lutz commented on patch set 3 02/05/26, 17:34

    StandardContentPreviewRenderer.php:120 Reply

    Done

    StandardContentPreviewRenderer.php:122 Reply

    Done

    GridColumnItem.php:184 Reply

    Done

    locallang_core.xlf:445 Reply

    Done
  2. core-ci voted on patch set 3 V +1 02/05/26, 17:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95194

  3. Bastien Lutz uploaded patch set 4 V +1 02/05/26, 18:33

  4. core-ci voted on patch set 4 V -1 02/05/26, 18:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95201

  5. Bastien Lutz uploaded patch set 5 V -1 02/05/26, 20:03

  6. Marno Schmigotzki voted on patch set 5 CR +1 V +1 02/05/26, 20:13

  7. Garvin Hicking commented on patch set 5 02/05/26, 20:38

    LanguageService.php:116

    oh nice driveby!!!
  8. core-ci voted on patch set 5 V +1 02/05/26, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95206

  9. Bastien Lutz rebased onto patch set 6 CR +1 V +1 02/10/26, 07:14

    The following files contain Git conflicts: * typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php
  10. Bastien Lutz uploaded patch set 7 02/10/26, 07:19

  11. core-ci voted on patch set 6 V -1 02/10/26, 07:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95524

  12. core-ci voted on patch set 7 V +1 02/10/26, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95525

  13. Bastien Lutz marked it ready for review 02/10/26, 07:33

  14. Oli Bartsch commented on patch set 7 V -1 02/10/26, 12:40

    Using the same labeling "Invalid Value" confuses a lot. Will update
  15. Oli Bartsch uploaded patch set 8 V +1 02/10/26, 13:45

  16. core-ci voted on patch set 8 V -1 02/10/26, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95548

  17. Bastien Lutz voted on patch set 8 CR +1 V +1 02/10/26, 14:27

  18. Oli Bartsch uploaded patch set 9 CR +1 V +1 02/10/26, 15:54

  19. core-ci voted on patch set 9 V -1 02/10/26, 16:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95559

  20. Oli Bartsch uploaded patch set 10 V -1 02/10/26, 16:09

  21. core-ci voted on patch set 10 V +1 02/10/26, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95560

  22. Georg Ringer voted on patch set 10 CR +1 V +1 02/10/26, 16:35

  23. Anja Leichsenring voted on patch set 10 CR +1 V +1 02/10/26, 19:08

  24. Oli Bartsch commented on patch set 10 CR +2 V +2 02/10/26, 22:07

    Reply

    Done
  25. Oli Bartsch merged patch set 11 02/10/26, 22:07