Review main Merged

92676[TASK] Migrate codeception InstallTool tests to playwright

Benjamin Kott CR +2 V +2 Expert +607 −649 updated 05/05/26, 10:01

Commit message

The patch migrates the InstallTool cests to a single playwright
spec in Build/tests/playwright/e2e/install-tool/.

The standalone install tool needs 'ENABLE_INSTALL_TOOL' file
present, which is harder to accomplish in playwright than with
codeception. The solution is to have a BE middleware that
creates the file, which can be called by tests. This is of
course a 'for testing purposes, only' solution, and lives
in a helper extension within monorepo Build/.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1316

  1. Benjamin Kott uploaded patch set 1 02/05/26, 09:27

  2. core-ci voted on patch set 1 V +1 02/05/26, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95115

  3. Benjamin Kott marked it work in progress 02/05/26, 23:09

  4. Christian Kuhn commented on patch set 1 05/04/26, 19:22

    PlaywrightHelperMiddleware.php:34

    that's a simple & straight approach. let's get this patch done. i'll push.
  5. Christian Kuhn commented on patch set 1 05/04/26, 19:23

    PlaywrightHelperMiddleware.php:34 Reply

    i'll add a fat warning this would be a security issue if used in the wild, though.
  6. Christian Kuhn uploaded patch set 2 V +1 05/04/26, 20:12

  7. core-ci voted on patch set 2 V +1 05/04/26, 20:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101496

  8. Christian Kuhn updated the commit message in patch set 3 V +1 05/04/26, 21:18

  9. Christian Kuhn commented on patch set 3 05/04/26, 21:18

    This change is ready for review.
  10. core-ci voted on patch set 3 V +1 05/04/26, 21:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101499

  11. Christian Kuhn voted on patch set 3 CR +1 V +1 05/04/26, 21:33

  12. Stefan Bürk voted on patch set 3 CR +1 V +1 05/04/26, 23:36

  13. Christian Kuhn voted on patch set 3 CR +2 V +2 05/04/26, 23:43

  14. Christian Kuhn merged patch set 4 05/05/26, 00:19

  15. Benjamin Franzke commented on patch set 4 05/05/26, 07:00

    PlaywrightHelperMiddleware.php:35

    @benjamin.kott@outlook.com We talked about this in the past that this is a NOGO, even in testing context. Also testing context needs some kind of security and these commands require a secret token that is generated and published into both contexts by the initializer. Since we expose the ports to the host, we must not introduce unauthenticated RPCs in local testing environments.
  16. Christian Kuhn commented on patch set 4 05/05/26, 10:01

    PlaywrightHelperMiddleware.php:35 Reply Unresolved