Review main Merged

92680[TASK] Use `static` return type for immutable methods in request classes

Elias Häußler CR +2 V +2 Normal +32 −42 updated 02/12/26, 18:45

Commit message

Immutable methods in `RequestInterface` implementations are designed for
extensibility and must therefore support late static binding. This is
already the case, but not yet reflected in various return types, which
is now streamlined.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 913

  1. Elias Häußler uploaded patch set 1 02/05/26, 10:59

  2. Elias Häußler uploaded patch set 2 02/05/26, 11:04

  3. core-ci voted on patch set 1 V -1 02/05/26, 11:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95131

  4. core-ci voted on patch set 2 V -1 02/05/26, 11:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95132

  5. Elias Häußler uploaded patch set 3 V -1 02/05/26, 11:14

  6. core-ci voted on patch set 3 V +1 02/05/26, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95133

  7. Georg Ringer voted on patch set 3 CR +1 V +1 02/05/26, 11:51

  8. Garvin Hicking updated the commit message in patch set 4 CR +1 V +1 02/06/26, 09:11

  9. core-ci voted on patch set 4 V +1 02/06/26, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95251

  10. Benni Mack voted on patch set 4 CR +1 V +1 02/12/26, 16:47

  11. Simon Schaufelberger voted on patch set 4 CR +1 V +1 02/12/26, 17:20

  12. Benni Mack voted on patch set 4 CR +2 V +2 02/12/26, 18:45

  13. Benni Mack merged patch set 5 02/12/26, 18:45