92683[TASK] Inform about missing permissions in new record wizard
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Oliver Hader +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 7
- Build/Sources/TypeScript/backend/new-record-wizard.ts+7 −1
- Build/Sources/TypeScript/dashboard/dashboard.ts+1 −0
- typo3/sysext/backend/Resources/Private/Templates/NewContentElement/Wizard.fluid.html+1 −0
- typo3/sysext/backend/Resources/Public/JavaScript/new-record-wizard.js+1 −1
- typo3/sysext/core/Resources/Private/Language/locallang_misc.xlf5+5 −2
- typo3/sysext/dashboard/Resources/Private/Language/locallang.xlf+3 −0
- typo3/sysext/dashboard/Resources/Public/JavaScript/dashboard.js+1 −1
Review log 1619
-
Juliane Wundermann uploaded patch set 1 02/05/26, 12:59
-
Juliane Wundermann uploaded patch set 2 02/05/26, 13:06
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 02/05/26, 13:07
-
core-ci voted on patch set 2 V +1 02/05/26, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95147
-
Oliver Hader commented on patch set 2 02/05/26, 13:20
On it... -
Oliver Hader uploaded patch set 3
CR +1V +102/05/26, 13:44 -
Oliver Hader commented on patch set 3 CR +1 V +1 02/05/26, 13:45
Reply
Done -
Riccardo De Contardi commented on patch set 3 02/05/26, 13:57
locallang_misc.xlf:70- here and in the other labels this seems a filling word and adds unnecessary emotional framing - the whole phrase sounds verbose and bureaucratic Some alternatives: 1. No content elements are available with your current permissions. 2. There are no content elements accessible with the current permission set. 3. There are currently no content elements you can access here. 4. No content elements are available for your user account in this context. -
core-ci voted on patch set 3 V +1 02/05/26, 13:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95151
-
Oliver Hader commented on patch set 3 02/05/26, 14:14
locallang_misc.xlf:70ReplyThanks for your feedback. I think `No content elements are available with your current permissions.` would be a good choice here. Adjusting the other occurrences of `Unfortunately` would be a generic and different change. -
Oliver Hader commented on patch set 3 02/05/26, 14:16
locallang_misc.xlf:70ReplyBut other than the labels, have you been able to verify that the patch works? -
Riccardo De Contardi commented on patch set 3 02/05/26, 14:21
locallang_misc.xlf:70Reply> But other than the labels, have you been able to verify that the patch works? will do. Agree with you for the other topic -
Juliane Wundermann uploaded patch set 4
CR +1V +102/05/26, 14:24 -
Juliane Wundermann commented on patch set 4 02/05/26, 14:26
locallang_misc.xlf:70ReplyDone -
core-ci voted on patch set 4 V +1 02/05/26, 14:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95159
-
Oliver Hader voted on patch set 4 CR +1 V +1 02/05/26, 14:41
-
Simon Schaufelberger voted on patch set 4 CR +1 V +1 02/05/26, 14:46
-
Oliver Hader voted on patch set 4 CR +2 V +2 02/05/26, 15:17
-
Oliver Hader merged patch set 5 02/05/26, 15:17