92687[BUGFIX] Throw clear exception when JavaScript module cannot be resolved
Commit message
Review
-
Code review CR 0
-
Verified V -1
- core-ci -1 CI
Issues 1
Files 1
Review log 67
-
Himanshu Nitsan uploaded patch set 1 02/05/26, 15:15
-
core-ci voted on patch set 1 V -1 02/05/26, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95170
-
Markus Klein commented on patch set 1 02/05/26, 15:57
I like the idea, but I'd go with a more specific exception. At least UnexpectedValueException or the like -
Himanshu Nitsan commented on patch set 1 02/06/26, 05:42
Reply
Good point. I’ve changed it to \UnexpectedValueException and updated the @throws on render(). Changes are pushed https://review.typo3.org/c/Packages/TYPO3.CMS/+/92698. -
Garvin Hicking commented on patch set 1 02/06/26, 06:08
Please always push to thecsamw patchset, using git commit --amend. Please either abandon this patch or the other to prevent dupes, thanks! -
Himanshu Nitsan commented on patch set 1 02/06/26, 07:02
Reply Unresolved
Thanks for the guidance. I’ll follow the git commit --amend workflow going forward. I’m abandoning this patch now. -
Himanshu Nitsan abandoned the change 02/06/26, 07:02
duplicate patch -> https://review.typo3.org/c/Packages/TYPO3.CMS/+/92698