Review main Abandoned

92687[BUGFIX] Throw clear exception when JavaScript module cannot be resolved

Himanshu Nitsan CR 0 V -1 Easy +21 −8 updated 02/06/26, 07:02

Commit message

When ImportMap::resolveImport() returns null for a module, JavaScriptRenderer
now throws a RuntimeException including the module name instead of a generic
TypeError, so developers can identify the missing or misconfigured module.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 1

Review log 67

  1. Himanshu Nitsan uploaded patch set 1 02/05/26, 15:15

  2. core-ci voted on patch set 1 V -1 02/05/26, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95170

  3. Markus Klein commented on patch set 1 02/05/26, 15:57

    I like the idea, but I'd go with a more specific exception. At least UnexpectedValueException or the like
  4. Himanshu Nitsan commented on patch set 1 02/06/26, 05:42

    Reply

    Good point. I’ve changed it to \UnexpectedValueException and updated the @throws on render(). Changes are pushed https://review.typo3.org/c/Packages/TYPO3.CMS/+/92698.
  5. Garvin Hicking commented on patch set 1 02/06/26, 06:08

    Please always push to thecsamw patchset, using git commit --amend. Please either abandon this patch or the other to prevent dupes, thanks!
  6. Himanshu Nitsan commented on patch set 1 02/06/26, 07:02

    Reply Unresolved

    Thanks for the guidance. I’ll follow the git commit --amend workflow going forward. I’m abandoning this patch now.
  7. Himanshu Nitsan abandoned the change 02/06/26, 07:02