Review main Merged

92689[BUGFIX] Properly check firstEL in EditDocumentController

Oli Bartsch CR +2 V +2 Easy +19 −10 updated 02/06/26, 12:52

Commit message

$firstEl might be null, e.g. on broken query params. This
needs to be checked properly across EditDocumentController.

Resolves: #108878
Related' #108586
Releases: main

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
    • Marno Schmigotzki +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
    • Marno Schmigotzki +1
    • core-ci +1 CI

Files 1

Review log 912

  1. Oli Bartsch uploaded patch set 1 02/05/26, 16:05

  2. core-ci voted on patch set 1 V -1 02/05/26, 16:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95180

  3. Marno Schmigotzki commented on patch set 1 02/05/26, 17:23

    EditDocumentController.php:828

    IMO this could fail
  4. Oli Bartsch uploaded patch set 2 V -1 02/05/26, 17:49

  5. Oli Bartsch commented on patch set 2 02/05/26, 17:49

    EditDocumentController.php:828 Reply

    Good catch, thanks!
  6. core-ci voted on patch set 2 V -1 02/05/26, 17:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95198

  7. Oli Bartsch uploaded patch set 3 V -1 02/06/26, 09:04

  8. core-ci voted on patch set 3 V +1 02/06/26, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95250

  9. Andreas Nedbal voted on patch set 3 CR +1 V +1 02/06/26, 10:51

  10. Marno Schmigotzki voted on patch set 3 CR +1 V +1 02/06/26, 12:29

  11. Oli Bartsch voted on patch set 3 CR +2 V +2 02/06/26, 12:52

  12. Oli Bartsch merged patch set 4 02/06/26, 12:52