Review main Abandoned

92692[TASK] Improve Configuration Module order

Matthias Vogel CR -2 V +1 Easy +6 −44 updated 10/17/26, 09:41

Commit message

The configuration select is now ordered by label.
It is no longer ordered by "before" and "after."

In the core, "before" and "after" have been removed.
Extension authors are not required to remove the tags,
they simply won't have any effect.

Review

  • Code review CR -2
    • Georg Ringer -2
    • Garvin Hicking +1
  • Verified V +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 2330

Show 45 earlier messages
  1. Matthias Vogel uploaded patch set 1 02/05/26, 16:25

  2. Simon Praetorius uploaded patch set 2 02/05/26, 16:32

  3. Oli Bartsch commented on patch set 2 02/05/26, 16:34

    What is the actual feature? I think this is more a TASK?
  4. core-ci voted on patch set 2 V -1 02/05/26, 16:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95186

  5. Simon Praetorius commented on patch set 2 02/05/26, 16:43

    I like that the order doesn't seem random anymore (like it did before), but I think we should try to find a low-end way to categorize those. Maybe we can add prefixes like "Backend: ", "Database: " or "System: " to those entries that don't have such a prefix yet?
  1. core-ci voted on patch set 1 V -1 02/05/26, 16:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95185

  2. Matthias Vogel uploaded patch set 3 V -1 02/05/26, 17:16

  3. Matthias Vogel commented on patch set 3 02/05/26, 17:17

    Reply

    Done
  4. core-ci voted on patch set 3 V -1 02/05/26, 17:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95191

  5. Matthias Vogel uploaded patch set 4 V -1 02/05/26, 20:02

  6. core-ci voted on patch set 4 V -1 02/05/26, 20:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95205

  7. Matthias Vogel rebased onto patch set 5 V -1 02/06/26, 07:04

  8. core-ci voted on patch set 5 V +1 02/06/26, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95239

  9. Matthias Vogel marked it work in progress 02/06/26, 13:06

  10. Matthias Vogel updated the commit message in patch set 6 V +1 02/10/26, 12:59

  11. Matthias Vogel marked it ready for review 02/10/26, 12:59

  12. core-ci voted on patch set 6 V +1 02/10/26, 13:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95544

  13. Garvin Hicking commented on patch set 6 02/10/26, 15:00

    I really dislike the current order, too. However, I feel this is a breaking change for some extensions that might utilize before/after. I think theoretically we should be able to define before/after properly to have the desired loading order? The label changes would also be welcome (by me) ;)
  14. Simon Praetorius commented on patch set 6 02/10/26, 15:23

    Reply

    What do you mean by "breaking"? Is there an error if before/after is used? Or is it just ignored? I personally wouldn't consider it a breaking change if a specified ordering in the list is just ignored.
  15. Garvin Hicking commented on patch set 6 02/10/26, 15:34

    Reply

    It would be something that is advertised and no longer works due to forced sorting. It's a rather internal service provider thing so that isn't tooo hard breaking for me. However. I think this would break the ability of third party extensions to put "their" stuff at a proper place, that's what I think we might better preserve.
  16. Georg Ringer commented on patch set 6 02/10/26, 15:49

    what is the benefit of removing this? even though we do that, I see that more as "breaking" which would not be allowed since 15.0
  17. Simon Schaufelberger voted on patch set 6 CR +1 V +1 02/10/26, 16:55

  18. Simon Praetorius commented on patch set 6 02/10/26, 17:13

    Reply

    > what is the benefit of removing this? You mean the manual ordering? Currently, the order is very confusing because everyone just chooses a random predecessor. I don't think it's a reasonable assumption that we get a more sane order if we allow manual ordering, especially if third-party modules get involved. We could of course enhance the select even further, e. g. by adding a grouping by extension or similar, but this would still make manual sorting more or less irrelevant. @typo3@kanti.de I think you reverted back to FEATURE, that was probably not intentional?
  19. Matthias Vogel updated the commit message in patch set 7 CR +1 V +1 02/10/26, 17:21

  20. core-ci voted on patch set 7 V +1 02/10/26, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95564

  21. Matthias Vogel commented on patch set 7 02/10/26, 17:44

    Reply

    They still can put "their" stuff at a proper place. Alphabetical inserter at the right place. I think of this as an UX/DX improvment. If the want to be at a specific position the need to rename there option so it is shorter at "the right place".
  22. Garvin Hicking commented on patch set 7 CR +1 V +1 02/10/26, 18:07

    Reply

    I've made my peace with this and my want to have a sane order is higher than the order. You've convinced me that custom ordering will probably always fail in this case. The order is purely cosmetic so I think it's fair.
  23. Georg Ringer commented on patch set 7 CR -2 02/10/26, 18:23

    we don't improve the behavior at all as the commit msg states. If the current ordering is bad (which I agreee at), then it doesn't get better at all if we order it now with an even worse ordering key - the label. > They still can put "their" stuff at a proper place. Alphabetical inserter at the right place. Isn't that what we have a real sorting mechanism for? I will hold my -2 until some core merger will convince me, or - if you want to order the current behavior by label, feel free to adopt the ordering with before & after, so that it is alphabetical AND if someone wants a specific position, it can be still done. No need to remove the sorting to achieve that.
  24. Oli Bartsch commented on patch set 7 02/10/26, 22:09

    Reply Unresolved

    I second that. I also think we should improve the ordering and also the labels but we should not do this static now.
  25. Matthias Vogel abandoned the change 10/17/26, 09:41