Review main Merged

92693[TASK] Add ElementBrowserParameters DTO for type-safe browser params

Benni Mack CR +2 V +2 Hard +874 −97 updated 02/23/26, 19:11

Commit message

The legacy pipe-delimited "bparams" string used for communication
between FormEngine and ElementBrowser has been replaced
with a proper typed DTO.

Example of the legacy format: "fieldRef|rteParams|rteConfig|allowedTypes|irreObjectId"
Example: "data[tt_content][123][image]|||gif,jpg|data-4-pages-4-nav_icon"

The new ElementBrowserParameters DTO provides type-safe access to
individual parameters, some helper methods and good conversion
factory methods, including backward compatibility

HTML data attributes have been updated from a single combined attribute:
  data-params="fieldRef|||allowed|objectId"

To separate, semantic attributes:
  data-field-reference="fieldRef"
  data-allowed-types="jpg,png"
  data-disallowed-types="exe,bat"
  data-irre-object-id="objectId"

Query parameters sent to the ElementBrowser have been updated accordingly,
replacing the single `bparams` parameter with separate parameters:
fieldReference, allowedTypes, disallowedFileExtensions, irreObjectId.

Full backward compatibility is kept: the DTO's fromRequest() method
automatically detects and parses the legacy bparams format when present.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 22

Show 2 more files

Review log 1118

  1. Benni Mack uploaded patch set 1 02/05/26, 17:07

  2. core-ci voted on patch set 1 V -1 02/05/26, 17:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95190

  3. Benni Mack uploaded patch set 2 V -1 02/22/26, 14:17

  4. core-ci voted on patch set 2 V -1 02/22/26, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96506

  5. Benni Mack uploaded patch set 3 V -1 02/22/26, 15:33

  6. core-ci voted on patch set 3 V -1 02/22/26, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96512

  7. Benni Mack uploaded patch set 4 V -1 02/23/26, 11:33

  8. Benni Mack marked it ready for review 02/23/26, 11:33

  9. core-ci voted on patch set 4 V +1 02/23/26, 11:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96563

  10. Benni Mack updated the commit message in patch set 5 V +1 02/23/26, 14:17

  11. core-ci voted on patch set 5 V -1 02/23/26, 14:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96584

  12. Benni Mack rebased onto patch set 6 V -1 02/23/26, 14:44

  13. core-ci voted on patch set 6 V -1 02/23/26, 15:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96586

  14. Benni Mack uploaded patch set 7 V -1 02/23/26, 16:55

  15. core-ci voted on patch set 7 V +1 02/23/26, 17:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96607

  16. Anja Leichsenring commented on patch set 7 CR +1 V +1 02/23/26, 18:04

    I hope I got the test right, but it looks good to me.
  17. Georg Ringer voted on patch set 7 CR +2 V +2 02/23/26, 19:11

  18. Georg Ringer merged patch set 8 02/23/26, 19:11