92696[BUGFIX] Use correct module in RecordBreadcrumbProvider
Commit message
Review
-
Code review CR 0
-
Verified V -1
- core-ci -1 CI
Issues 1
Files 3
Review log 1117
-
Georg Ringer uploaded patch set 1 02/05/26, 20:14
-
Georg Ringer commented on patch set 1 02/05/26, 20:14
This change is ready for review. -
core-ci voted on patch set 1 V -1 02/05/26, 20:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95208
-
Georg Ringer uploaded patch set 2
V -102/09/26, 13:53 -
core-ci voted on patch set 2 V -1 02/09/26, 14:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95468
-
Georg Ringer uploaded patch set 3
V -102/09/26, 14:40 -
core-ci voted on patch set 3 V +1 02/09/26, 15:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95471
-
Anja Leichsenring commented on patch set 3 02/09/26, 19:49
not too happy about this approach. It works nicely when in layout module, but when clicking in record module, I land in layout. Staying where I am would be more intuitive. Why did you change the behaviour in this way, when only record_edit needs a redirect? I think it would make sense to apply the filter only when the module is not the edit module.RecordBreadcrumbProvider.php:66Unresolvedthe variable is unused and can be removed here. -
Anja Leichsenring commented on patch set 3 02/09/26, 20:07
Reply
right, too many 'not's. I meant to say a redirect should only happen if the module is record_edit or any other error prone one, but not when in either layout or records. Where else are breadcrumbs and need to be considered? -
Georg Ringer uploaded patch set 4
V +102/10/26, 20:10 -
core-ci voted on patch set 4 V -1 02/10/26, 20:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95573
-
Benni Mack wrote 04/21/26, 15:03
Removed reviewer Benni Mack. -
Benni Mack updated the commit message in patch set 5
V -104/22/26, 07:15 -
core-ci voted on patch set 5 V -1 04/22/26, 12:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100853
-
Benni Mack rebased onto patch set 6
V -110/22/26, 15:42 -
core-ci voted on patch set 6 V -1 10/22/26, 16:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112136
-
Garvin Hicking abandoned the change 10/23/26, 06:28
no longer reproducible