Review main Merged

92697[BUGFIX] Keep preview iframe edge under the pointer while resizing

Georg Ringer CR +2 V +2 Easy +9 −2 updated 10/17/26, 00:19

Commit message

The preview iframe in the view module is centered. Resizing it
horizontally grows the element on both sides, so its edge moves
only half as far as the pointer and gets out of sync.

The horizontal size change is now doubled while resizing, so the
dragged edge follows the pointer. Both handles and the centered
layout are kept, which preserves RTL support.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Wouter Wolters +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1114

  1. Georg Ringer uploaded patch set 1 02/05/26, 20:54

  2. core-ci voted on patch set 1 V +1 02/05/26, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95213

  3. Georg Ringer uploaded patch set 2 V +1 10/10/26, 05:42

  4. Georg Ringer commented on patch set 2 10/10/26, 05:43

    This change is ready for review.
  5. core-ci voted on patch set 2 V +1 10/10/26, 05:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110753

  6. Andreas Kienast commented on patch set 2 V -1 10/10/26, 16:39

    This breaks RTL support, as the "west"-oriented handle is now removed.

    main.ts:119

    This looks superfluous now.
  7. Georg Ringer uploaded patch set 3 V +1 10/11/26, 12:41

  8. core-ci voted on patch set 3 V +1 10/11/26, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110851

  9. Andreas Kienast commented on patch set 3 CR +1 V +1 10/12/26, 05:41

    Thanks, I like this approach even more.
  10. Andreas Kienast commented on patch set 3 10/12/26, 05:42

    Reply

    Done

    main.ts:119 Reply

    Done
  11. Wouter Wolters voted on patch set 3 CR +1 V +1 10/12/26, 17:46

  12. Georg Ringer voted on patch set 3 CR +2 V +2 10/16/26, 17:53

  13. Georg Ringer merged patch set 4 10/16/26, 17:53

  14. Simon Schaufelberger commented on patch set 4 10/17/26, 00:19

    Unresolved

    @georg.ringer@gmail.com why is this not backported to v14?