Review main Merged

92700[BUGFIX] Use correct data attribute for modals

Georg Ringer CR +2 V +2 Easy +2 −2 updated 02/07/26, 10:33

Commit message

After #107443 the data attributes need to changed from bs-content to content.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Guido Schmechel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • Guido Schmechel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1214

  1. Georg Ringer uploaded patch set 1 02/06/26, 07:35

  2. Georg Ringer commented on patch set 1 02/06/26, 07:36

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 02/06/26, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95243

  4. Garvin Hicking commented on patch set 1 02/06/26, 07:46

    @georg.ringer@gmail.com I can see a more places in the core when grepping for it: Languagecolumns.fluid.html SelectCheckBoxElement.php FileList.php Do these need adoption too?!
  5. Georg Ringer commented on patch set 1 02/06/26, 08:09

    Reply

    I saw those too and those work with the bs-content, I wondering myself as well but didn't want to change code which seems still to work
  6. Garvin Hicking commented on patch set 1 CR +1 V +1 02/06/26, 08:37

    Reply

    Check. Probably related due to `t3js-modal-trigger` where explicitly needed. Verified your patch as working.
  7. Riccardo De Contardi commented on patch set 1 02/06/26, 08:43

    as far as I have seen on FileList.php the usage of bs-content triggers the console error about wrong attribute used (defined in Build/Sources/TypeScript/backend/modal.ts - see initializeMarkupTrigger)
  8. Garvin Hicking rebased onto patch set 2 CR +1 V +1 02/06/26, 13:02

  9. core-ci voted on patch set 2 V +1 02/06/26, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95288

  10. Garvin Hicking voted on patch set 2 CR +1 V +1 02/06/26, 16:30

  11. Simon Schaufelberger voted on patch set 2 CR +1 V +1 02/06/26, 17:48

  12. Guido Schmechel voted on patch set 2 CR +1 V +1 02/07/26, 10:31

  13. Georg Ringer voted on patch set 2 CR +2 V +2 02/07/26, 10:33

  14. Georg Ringer merged patch set 3 02/07/26, 10:33