Review main Abandoned

92701[TASK] Allow fields of TCA types select,checkbox in reactions

Georg Ringer CR 0 V -1 Easy +1 −1 updated 09/18/26, 13:14

Commit message

Add `select` and `check` for allowed fields in reactions.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 1

Review log 1214

  1. Georg Ringer uploaded patch set 1 02/06/26, 07:55

  2. Georg Ringer commented on patch set 1 02/06/26, 07:55

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 02/06/26, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95244

  4. Rémi Payette voted on patch set 1 V +1 02/06/26, 23:28

  5. Peter Kraume voted on patch set 1 CR +1 V +1 02/07/26, 07:40

  6. Guido Schmechel voted on patch set 1 CR +1 V +1 02/07/26, 10:45

  7. Simon Schaufelberger voted on patch set 1 CR +1 V +1 02/10/26, 20:51

  8. Oli Bartsch commented on patch set 1 V -1 02/10/26, 21:31

    Sorry but let me check this please. I assume there was a reason to limit this.
  9. Oli Bartsch commented on patch set 1 02/10/26, 21:59

    Reply

    Checked this. This breaks the UX in the corresponding reaction records because these fields are currently rendered via the special FormEngine element without any type-specific handling, simply as input fields. The actual type is not visible to the integrator, so checkboxes and select fields would not be recognizable as such. Adding default values in this context is also highly error-prone. Furthermore, using placeholders could cause issues with foreign relations, even when handled via the DataHandler. I understand that this would be a valuable addition to reactions, but it needs to be implemented comprehensively. This should include proper handling and display of these types in the FieldMapElement, as well as tests to ensure correct reference indexing and relation resolution.
  10. Rémi Payette commented on patch set 1 02/11/26, 19:44

    Reply

    I understand that it's not the optimal way to implement that. On the other hand, reactions are api call from other systems linked to Typo3, I would consider them to be more a backend developper function than a Typo3 integrator one.
  11. Oli Bartsch commented on patch set 1 02/12/26, 07:50

    Reply Unresolved

    Absolutely, I agree that we should ship this. However, it needs to be implemented properly. Simply adding those two keys to the array is not sufficient.
  12. Benni Mack updated the commit message in patch set 2 CR +1 V +1 04/22/26, 06:39

  13. core-ci voted on patch set 2 V -1 04/22/26, 10:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100752

  14. Georg Ringer abandoned the change 09/18/26, 13:14